-
-
Notifications
You must be signed in to change notification settings - Fork 167
feat!: Upgrade AWS provider and min required Terraform version to 6.9 and 1.5.7 respectively
#68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Upgrade AWS provider and min required Terraform version to 6.9 and 1.5.7 respectively
#68
Conversation
…9` and `1.5.7` respectively
| ] | ||
| }) | ||
|
|
||
| inline_policy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is deprecated so followed the provider recommendation to switch to aws_iam_role_policy
| success_role_arn = optional(string) | ||
| success_sample_rate = optional(number) | ||
| }) | ||
| default = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're using a default of {} because we are technically globbing 3 arguments into one, not using a dynamic argument with nested fields. otherwise, if we use null, we'd have to continue wrapping in a try():
application_failure_feedback_role_arn = try(var.application_feedback.failure_role_arn, null)
instead of:
application_failure_feedback_role_arn = var.application_feedback.failure_role_arn
antonbabenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
## [7.0.0](v6.2.1...v7.0.0) (2025-10-22) ### ⚠ BREAKING CHANGES * Upgrade AWS provider and min required Terraform version to `6.9` and `1.5.7` respectively (#68) ### Features * Upgrade AWS provider and min required Terraform version to `6.9` and `1.5.7` respectively ([#68](#68)) ([f9269fb](f9269fb))
|
This PR is included in version 7.0.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
6.9and1.5.7respectivelyregionargument to relevant resourcesanyormap(string)create = falseMotivation and Context
regionresource level argumentBreaking Changes
Caution
There are no changes for users other than one small change to match the underlying API. Within
topic_policy_statements, theconditionargument was previouslyconditions(plural). See this change for referenceHow Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request