Skip to content

Conversation

@bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Oct 22, 2025

Description

  • Upgrade AWS provider and min required Terraform version to 6.9 and 1.5.7 respectively
  • Add support for resource level region argument to relevant resources
  • Add variable optional attributes to replace vague variable types of any or map(string)
  • Ensure no resources or data sources are invoke if create = false

Motivation and Context

Breaking Changes

  • Yes, due to raising the min required versions across major versions.

Caution

There are no changes for users other than one small change to match the underlying API. Within topic_policy_statements, the condition argument was previously conditions (plural). See this change for reference

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

]
})

inline_policy {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is deprecated so followed the provider recommendation to switch to aws_iam_role_policy

success_role_arn = optional(string)
success_sample_rate = optional(number)
})
default = {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're using a default of {} because we are technically globbing 3 arguments into one, not using a dynamic argument with nested fields. otherwise, if we use null, we'd have to continue wrapping in a try():

application_failure_feedback_role_arn    = try(var.application_feedback.failure_role_arn, null)

instead of:

  application_failure_feedback_role_arn    = var.application_feedback.failure_role_arn

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bryantbiggs bryantbiggs merged commit f9269fb into terraform-aws-modules:master Oct 22, 2025
6 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 22, 2025
## [7.0.0](v6.2.1...v7.0.0) (2025-10-22)

### ⚠ BREAKING CHANGES

* Upgrade AWS provider and min required Terraform version to `6.9` and `1.5.7` respectively (#68)

### Features

* Upgrade AWS provider and min required Terraform version to `6.9` and `1.5.7` respectively ([#68](#68)) ([f9269fb](f9269fb))
@antonbabenko
Copy link
Member

This PR is included in version 7.0.0 🎉

@bryantbiggs bryantbiggs deleted the feat/upgrade branch October 22, 2025 17:16
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants