|
| 1 | +From 2ec75f1d098e35b37fcda15962dd02bb2eb85c73 Mon Sep 17 00:00:00 2001 |
| 2 | +From: Biswapriyo Nath <nathbappai@gmail.com> |
| 3 | +Date: Wed, 1 Jan 2025 00:00:00 +0000 |
| 4 | +Subject: [PATCH] aidl: Fix ambiguous dump_location function |
| 5 | + |
| 6 | +Fixes: |
| 7 | +generate_aidl_mappings.cpp:48:48: error: call of overloaded 'dump_location(AidlMethod&)' is ambiguous |
| 8 | +generate_java.cpp:979:72: error: call of overloaded 'dump_location(const AidlAnnotation&)' is ambiguous |
| 9 | +--- |
| 10 | + generate_aidl_mappings.cpp | 2 +- |
| 11 | + generate_java.cpp | 2 +- |
| 12 | + 2 files changed, 2 insertions(+), 2 deletions(-) |
| 13 | + |
| 14 | +diff --git a/generate_aidl_mappings.cpp b/generate_aidl_mappings.cpp |
| 15 | +index 8acd85cc1f51..d1e9c8a999e9 100644 |
| 16 | +--- a/generate_aidl_mappings.cpp |
| 17 | ++++ b/generate_aidl_mappings.cpp |
| 18 | +@@ -45,7 +45,7 @@ SignatureMap generate_mappings(const AidlDefinedType* defined_type) { |
| 19 | + } |
| 20 | + signature << "|"; |
| 21 | + signature << java::JavaSignatureOf(method->GetType()); |
| 22 | +- mappings[signature.str()] = dump_location(*method); |
| 23 | ++ mappings[signature.str()] = android::aidl::mappings::dump_location(*method); |
| 24 | + } |
| 25 | + } |
| 26 | + return mappings; |
| 27 | +diff --git a/generate_java.cpp b/generate_java.cpp |
| 28 | +index 4263c11531a3..0f6c580c6e09 100644 |
| 29 | +--- a/generate_java.cpp |
| 30 | ++++ b/generate_java.cpp |
| 31 | +@@ -976,7 +976,7 @@ std::string GenerateJavaUnsupportedAppUsageParameters(const AidlAnnotation& a) { |
| 32 | + const std::string& param_value = name_and_param.second; |
| 33 | + parameters_decl.push_back(param_name + " = " + param_value); |
| 34 | + } |
| 35 | +- parameters_decl.push_back("overrideSourcePosition=\"" + dump_location(a) + "\""); |
| 36 | ++ parameters_decl.push_back("overrideSourcePosition=\"" + android::aidl::java::dump_location(a) + "\""); |
| 37 | + return "(" + Join(parameters_decl, ", ") + ")"; |
| 38 | + } |
| 39 | + |
| 40 | +-- |
| 41 | +2.54.0 |
| 42 | + |
0 commit comments