-
Notifications
You must be signed in to change notification settings - Fork 112
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Describe the solution you'd like
Plugins need to be able to be provided to replayers. The problem is worker plugins have a lot of config that a replayer does not, but there are important shared things like interceptors. We're going to have to decide which option we want, here are a few:
- Add
configure_replayer
+run_replayer
onworker.Plugin
making every plugin author to add extra code to configure common things like interceptors - Try to reuse
configure_worker
+run_worker
knowing there are a ton of config options and worker instance stuff that doesn't overlap - Have a completely separate
worker.ReplayerPlugin
which has same problem as first bullet, but at least will give type error when trying to register when creating replayer
This same problem will need to be solved in other languages too. The third is probably the best so we can keep API clean and plugin authors can just choose not to support replayer if they want.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request