Skip to content

Snapshot limit check order of operations could be optimized #983

@danflo27

Description

@danflo27

In report snapshot creation, limit checks should happen before snapshot creation work to avoid unnecessary processing when limit is zero.

  • x/bridge/keeper/keeper.go:945-948 (snapshotlimit.Limit check/decrement in CreateNewReportSnapshots)

Fix:
In CreateNewReportSnapshots, check if snapshotlimit.Limit == 0 { break } before CreateSnapshot(...)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions