Skip to content

Commit f3218c0

Browse files
JuanMartinPfgalan
andauthored
Apply suggestions from code review
Co-authored-by: Fermín Galán Márquez <[email protected]>
1 parent 0abf698 commit f3218c0

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

python-lib/tc_etl_lib/README.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -247,24 +247,24 @@ import tc_etl_lib as tc
247247

248248
# declare objectStorageManager
249249
object_storage_manager = tc.objectStorageManager(endpoint='<http/https>://<object_storage_endpoint>:<port>',
250-
access_key='<user>',
251-
secret_key='<password>')
250+
access_key='<user>',
251+
secret_key='<password>')
252252

253253
# Upload test-file.txt to python-test-bucket/output/example.txt
254254
# note test-file.txt must exist in the same directory where this example is run
255255
object_storage_manager.upload_file(bucket_name='python-test-bucket',
256-
destination_file='/output/example.txt',
257-
source_file="test-file.txt")
256+
destination_file='/output/example.txt',
257+
source_file="test-file.txt")
258258

259259
# You can define your own custom processing method and use it in the processing_method argument of the process_file method
260260
def process_chunk(file_chunk):
261261
print(file_chunk)
262262

263263
# Retrieve example.txt and apply custom method to each 3 bytes chunk
264264
object_storage_manager.process_file(bucket_name='python-test-bucket',
265-
destination_file='/output/example.txt',
266-
chunk_size=3,
267-
processing_method=process_chunk)
265+
destination_file='/output/example.txt',
266+
chunk_size=3,
267+
processing_method=process_chunk)
268268

269269
# Remove the bucket created in the upload file method
270270
object_storage_manager.remove_bucket("python-test-bucket")
@@ -566,8 +566,7 @@ TOTAL 403 221 45%
566566
## Changelog
567567

568568

569-
- Change: replace `minioManager` backend library to use aws `boto3`
570-
- Add: new class `minioManager` to manage MinIO connection and file processing ([#109](https://github.com/telefonicasc/etl-framework/issues/109))
569+
- Add: new class `objectStorageBucket` to manage bucket based object storage compatible with S3 API (such as AWS S3 or MINIMO) ([#109](https://github.com/telefonicasc/etl-framework/issues/109))
571570

572571
0.16.0 (September 29th, 2025)
573572

0 commit comments

Comments
 (0)