Merge pull request #79 from telefonicasc/kevin/finally-in-etl

feat: del and init handle warning

Author: fgalan

python-lib/tc_etl_lib/README.md

@@ -505,6 +505,8 @@ TOTAL                        403    221    45%
 
 ## Changelog
 
+- Fix: close session upon finalization to avoid warnings ([#76](https://github.com/telefonicasc/etl-framework/pull/76))
+
 0.10.0 (November 29th, 2023)
 
 - Add: new class `iotaManager` to deal with IoT Agent interactions, with methods `send_http` and `send_batch_http`([#55](https://github.com/telefonicasc/etl-framework/issues/55))

python-lib/tc_etl_lib/tc_etl_lib/cb.py

@@ -72,6 +72,7 @@ class cbManager:
     # reasons other than block size (e.g to avoid triggering too
     # many subscriptions per batch and stressing cygnus queues)
     batch_size = 0
+    session = None
 
     def __init__(self,*, endpoint: Optional[str] = None, timeout: int = 10, post_retry_connect: int = 3, post_retry_backoff_factor: int = 20, sleep_send_batch: int = 0, cb_flowcontrol: bool = False, block_size: int = 800000, batch_size: int = 0) -> None:
 
@@ -85,13 +86,19 @@ def __init__(self,*, endpoint: Optional[str] = None, timeout: int = 10, post_ret
         self.sleep_send_batch = sleep_send_batch
         self.cb_flowcontrol = cb_flowcontrol
         self.batch_size = batch_size
+        self.session = requests.Session()
 
         # check block_size limit.
         if (int(block_size) > int(800000)):
             raise ValueError('Block size limit reached! <<block_size>> value cannot be greater than 800000')
 
         self.block_size = block_size
 
+    def __del__(self):
+        try:
+            self.session.close()
+        except Exception:  # pylint: disable=broad-except
+            logger.error(f'Error closing session with endpoint: {self.endpoint}')
 
     def delete_entities(self, *, service: str = None, subservice: str = None, auth: authManager = None, limit: int = 100, type: str = None, q: str = None, mq: str = None, georel: str = None, geometry: str = None, coords: str = None, id: str = None, options_get: list = [], options_send: list = []):
         """Delete data from context broker
@@ -390,7 +397,7 @@ def __batch_creation(self, *, service: str = None, subservice: str = None, auth:
         else:
             req_url = f"{self.endpoint}/v2/op/update"
 
-        http = requests.Session()
+        http = self.session
         retry_strategy = Retry(
             total=self.post_retry_connect,
             read=self.post_retry_connect,