fix(release): copy vendor tarball into kodata instead of symlink#1791
Merged
tekton-robot merged 1 commit intoJul 10, 2026
Merged
Conversation
tekton-robot
added
the
size/S
ko v0.19.0 enforces that kodata symlinks must not resolve outside the kodata root (ko-build/ko#1619). The run-ko step symlinked cmd/*/kodata/source.tar.gz to a file in an external tmpdir, which ko now rejects, breaking patch-release image publishing. Copy the tarball into each kodata/ directory instead. ko already dereferences symlinks when tarring kodata, so this has no effect on final image size. Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 5 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
jkhelil
force-pushed
the
fix/release-ko-kodata-symlink
branch
from
0768afa to
8f3f118
Compare
tekton-robot
added
size/XS
Contributor
|
/lgtm |
vdemeester
approved these changes
Jul 10, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Member
Author
|
/cherry-pick release-v0.28.x |
|
✅ Cherry-pick to A new pull request has been created to cherry-pick this change to PR: #1792 Please review and merge the cherry-pick PR. |
5 tasks
Member
Author
|
We cant wait for ko-build/ko#1698 to be release |
This was referenced Jul 10, 2026
Contributor
|
/cherry-pick release-v0.26.x |
Contributor
|
/cherry-pick release-v0.27.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
kov0.19.0 enforces thatkodata/symlinks must not resolve outside thekodata root (ko-build/ko#1619), a deliberate security hardening. This broke
the
run-kostep in our release pipeline, which symlinkedcmd/*/kodata/source.tar.gzto a tarball in an externalmktemp -ddirectory:
This surfaced during a
v0.28.0patch release after bumping the pinnedkoimage digest for Go 1.26.4 support (#1778), which pulled inkov0.19.1.Fix: copy the vendor tarball into each
cmd/*/kodata/directory instead ofsymlinking to it from a shared tmpdir.
koalready dereferences symlinksand embeds the resolved file's bytes into the image layer when tarring
kodata, so this has no effect on the final image size — only the symlink
itself was rejected, not the underlying content.
Applied the same fix to the historical
examples/releases/v0.3.0-build-chains-taskrun.yamlfor consistency, since it has the identical pattern.
Note:
tektoncd/pipeline'stekton/publish.yamlhas the same unfixedpattern and is pinned to the same
kov0.19.1 image family, so it's likelyexposed to the same issue.
Submitter Checklist
/kind bugMade with Cursor