Skip to content

fix(ci): pin ko binary to v0.18.1 for release-v0.20.x e2e tests#1790

Merged
jkhelil merged 1 commit into
tektoncd:dependabot/github_actions/release-v0.20.x/all-da38176bedfrom
infernus01:fix-ko-pin-v0.20.x
Jul 10, 2026
Merged

fix(ci): pin ko binary to v0.18.1 for release-v0.20.x e2e tests#1790
jkhelil merged 1 commit into
tektoncd:dependabot/github_actions/release-v0.20.x/all-da38176bedfrom
infernus01:fix-ko-pin-v0.20.x

Conversation

@infernus01

Copy link
Copy Markdown
Member

Changes

Pin ko binary version to v0.18.1 in the e2e workflow for
release-v0.20.x.

Problem

The setup-ko action had no version: input, so it defaulted to
latest-release. ko v0.19.1 introduced a security change that
rejects kodata symlinks resolving outside the kodata root:

kodata symlink "HEAD" resolves to ".git/HEAD" which is outside
the kodata root

This breaks ko apply because cmd/controller/kodata/HEAD and
cmd/controller/kodata/refs are symlinks into .git/ for version
embedding. All e2e tests fail since the controller image can't be
built.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2026
@anithapriyanatarajan

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026
@anithapriyanatarajan

Copy link
Copy Markdown
Contributor

@jkhelil - I think pinning is ok on old branch

@jkhelil

jkhelil commented Jul 10, 2026

Copy link
Copy Markdown
Member

probably yes

@jkhelil

jkhelil commented Jul 10, 2026

Copy link
Copy Markdown
Member

/approve

@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jkhelil
To complete the pull request process, please assign wlynch after the PR has been reviewed.
You can assign the PR to them by writing /assign @wlynch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkhelil jkhelil merged commit 06e05cd into tektoncd:dependabot/github_actions/release-v0.20.x/all-da38176bed Jul 10, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants