Merge pull request #44 from teesofttech/chore/resolve-nullable-warnings

Resolve nullable warnings

Author: teesofttech

src/TableauSharp/Common/Models/ErrorResponse.cs

@@ -5,11 +5,11 @@ namespace TableauSharp.Common.Models;
 public class ErrorResponse
 {
     [JsonPropertyName("code")]
-    public string Code { get; set; }
+    public string Code { get; set; } = string.Empty;
 
     [JsonPropertyName("summary")]
-    public string Summary { get; set; }
+    public string Summary { get; set; } = string.Empty;
 
     [JsonPropertyName("detail")]
-    public string Detail { get; set; }
-}
+    public string Detail { get; set; } = string.Empty;
+}

src/TableauSharp/Embedding/Models/TrustedTicketRequest.cs

@@ -2,7 +2,7 @@ namespace TableauSharp.Embedding.Models;
 
 public class TrustedTicketRequest
 {
-    public string Username { get; set; }
-    public string ClientIp { get; set; }
-    public string TargetSite { get; set; }
-}
+    public string Username { get; set; } = string.Empty;
+    public string? ClientIp { get; set; }
+    public string? TargetSite { get; set; }
+}

src/TableauSharp/Embedding/Models/TrustedTicketResponse.cs

@@ -2,6 +2,6 @@ namespace TableauSharp.Embedding.Models;
 
 public class TrustedTicketResponse
 {
-    public string TicketId { get; set; }
-    public string EmbedUrl { get; set; }
-}
+    public string TicketId { get; set; } = string.Empty;
+    public string EmbedUrl { get; set; } = string.Empty;
+}

src/TableauSharp/Embedding/Services/EmbeddingService.cs

@@ -40,10 +40,14 @@ public async Task<TrustedTicketResponse> GetTrustedTicketAsync(TrustedTicketRequ
 
         var form = new Dictionary<string, string>
         {
-            { "username", request.Username },
-            { "target_site", request.TargetSite }
+            { "username", request.Username }
         };
 
+        if (!string.IsNullOrEmpty(request.TargetSite))
+        {
+            form.Add("target_site", request.TargetSite);
+        }
+
         if (!string.IsNullOrEmpty(request.ClientIp))
         {
             form.Add("client_ip", request.ClientIp);

src/TableauSharp/Permissions/Models/PermissionCapabilityAssignment.cs

@@ -9,5 +9,5 @@ public class PermissionCapabilityAssignment
     public PermissionCapability Capability { get; set; }
 
     [JsonPropertyName("mode")]
-    public string Mode { get; set; } // "Allow" or "Deny"
-}
+    public string Mode { get; set; } = string.Empty; // "Allow" or "Deny"
+}

src/TableauSharp/Permissions/Models/PermissionSyncRequest.cs

@@ -2,6 +2,6 @@ namespace TableauSharp.Permissions.Models;
 
 public class PermissionSyncRequest
 {
-    public string TargetId { get; set; }
+    public string TargetId { get; set; } = string.Empty;
     public List<TableauPermission> Permissions { get; set; } = new();
-}
+}

src/TableauSharp/Permissions/Models/TableauPermission.cs

@@ -5,11 +5,11 @@ namespace TableauSharp.Permissions.Models;
 public class TableauPermission
 {
     [JsonPropertyName("granteeId")]
-    public string GranteeId { get; set; }
+    public string GranteeId { get; set; } = string.Empty;
 
     [JsonPropertyName("granteeType")]
-    public string GranteeType { get; set; } // "User" or "Group"
+    public string GranteeType { get; set; } = string.Empty; // "User" or "Group"
 
     [JsonPropertyName("capabilities")]
     public List<PermissionCapabilityAssignment> Capabilities { get; set; } = new();
-}
+}

src/TableauSharp/Projects/Models/ProjectCreateRequest.cs

@@ -2,7 +2,7 @@ namespace TableauSharp.Projects.Models;
 
 public class ProjectCreateRequest
 {
-    public string Name { get; set; }
-    public string Description { get; set; }
-    public string ParentProjectId { get; set; }
-}
+    public string Name { get; set; } = string.Empty;
+    public string? Description { get; set; }
+    public string? ParentProjectId { get; set; }
+}

src/TableauSharp/Projects/Models/ProjectUpdateRequest.cs

@@ -2,6 +2,6 @@ namespace TableauSharp.Projects.Models;
 
 public class ProjectUpdateRequest
 {
-    public string Name { get; set; }
-    public string Description { get; set; }
-}
+    public string? Name { get; set; }
+    public string? Description { get; set; }
+}

src/TableauSharp/Projects/Models/TableauProject.cs

@@ -5,17 +5,17 @@ namespace TableauSharp.Projects.Models;
 public class TableauProject
 {
     [JsonPropertyName("id")]
-    public string Id { get; set; }
+    public string Id { get; set; } = string.Empty;
 
     [JsonPropertyName("name")]
-    public string Name { get; set; }
+    public string Name { get; set; } = string.Empty;
 
     [JsonPropertyName("description")]
-    public string Description { get; set; }
+    public string? Description { get; set; }
 
     [JsonPropertyName("parentProjectId")]
-    public string ParentProjectId { get; set; }
+    public string? ParentProjectId { get; set; }
 
     [JsonPropertyName("ownerId")]
-    public string OwnerId { get; set; }
-}
+    public string? OwnerId { get; set; }
+}