Skip to content

Commit 0922a40

Browse files
committed
don't return error when parseparams fails
I remember now that I was doing this to stop issues with grafana making extra queries that are not handled.
1 parent d85f725 commit 0922a40

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

server.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,13 @@ func (s *Server) ServeHTTP(resp http.ResponseWriter, req *http.Request) {
7474
}
7575
params, err := s.ParseParams(req.Form)
7676
if err != nil {
77-
fmt.Printf("Failed to parse params: %s\n", err)
77+
fmt.Printf("Failed to parse params: %s: %+v\n", err, req.Form)
7878
resp.WriteHeader(http.StatusBadRequest)
79-
errorJson(err, resp)
79+
_, err = resp.Write([]byte("{}"))
80+
if err != nil {
81+
fmt.Printf("Error writing response to client: %+v\n", err)
82+
}
83+
//errorJson(err, resp)
8084
return
8185
}
8286

0 commit comments

Comments
 (0)