Does not run on Blue Pill STM32F103

[chrysophylax]

Trying to run the latest version on the official STM32 Core v 1.9.0 Arduino board gives me a bunch of errors in the IDE.
What's the last known working version?

/home/billy/Arduino/ulisp.cpp/ulisp.cpp.ino: In function 'void FlashSetup()':
ulisp.cpp:383:3: error: 'FLASH_Unlock' was not declared in this scope; did you mean 'HAL_FLASH_Unlock'?
  383 |   FLASH_Unlock();
      |   ^~~~~~~~~~~~
      |   HAL_FLASH_Unlock
ulisp.cpp:386:14: error: 'FLASH_ErasePage' was not declared in this scope
  386 |     Status = FLASH_ErasePage(page);
      |              ^~~~~~~~~~~~~~~
ulisp.cpp:387:19: error: 'FLASH_COMPLETE' was not declared in this scope; did you mean 'FLASH_CR_PER'?
  387 |     if (Status != FLASH_COMPLETE) error2(SAVEIMAGE, PSTR("flash erase failed"));
      |                   ^~~~~~~~~~~~~~
      |                   FLASH_CR_PER
/home/billy/Arduino/ulisp.cpp/ulisp.cpp.ino: In function 'void FlashWrite16(unsigned int*, uint16_t)':
ulisp.cpp:392:21: error: 'FLASH_ProgramHalfWord' was not declared in this scope
  392 |   uint16_t Status = FLASH_ProgramHalfWord((*addr) + Eeprom, data);
      |                     ^~~~~~~~~~~~~~~~~~~~~
ulisp.cpp:393:17: error: 'FLASH_COMPLETE' was not declared in this scope; did you mean 'FLASH_CR_PER'?
  393 |   if (Status != FLASH_COMPLETE) error2(SAVEIMAGE, PSTR("flash write failed"));
      |                 ^~~~~~~~~~~~~~
      |                 FLASH_CR_PER
/home/billy/Arduino/ulisp.cpp/ulisp.cpp.ino: In function 'uint16_t FlashRead16(unsigned int*)':
ulisp.cpp:464:27: error: ISO C++ forbids declaration of 'type name' with no type [-fpermissive]
  464 |   uint16_t data = (*(__IO uint16*)((*addr) + Eeprom));
      |                           ^~~~~~
In file included from /home/billy/.arduino15/packages/STM32/hardware/stm32/1.9.0/system/Drivers/CMSIS/Device/ST/STM32F1xx/Include/stm32f103xb.h:132,
                 from /home/billy/.arduino15/packages/STM32/hardware/stm32/1.9.0/system/Drivers/CMSIS/Device/ST/STM32F1xx/Include/stm32f1xx.h:131,
                 from /home/billy/.arduino15/packages/STM32/hardware/stm32/1.9.0/cores/arduino/stm32/stm32_def.h:28,
                 from /home/billy/.arduino15/packages/STM32/hardware/stm32/1.9.0/cores/arduino/stm32/clock.h:43,
                 from /home/billy/.arduino15/packages/STM32/hardware/stm32/1.9.0/cores/arduino/wiring_time.h:23,
                 from /home/billy/.arduino15/packages/STM32/hardware/stm32/1.9.0/cores/arduino/wiring.h:38,
                 from /home/billy/.arduino15/packages/STM32/hardware/stm32/1.9.0/cores/arduino/Arduino.h:36,
                 from sketch/ulisp.cpp.ino.cpp:1:
/home/billy/.arduino15/packages/STM32/tools/CMSIS/5.5.1/CMSIS/Core/Include/core_cm3.h:170:21: error: expected primary-expression before 'volatile'
  170 | #define     __IO    volatile             /*!< Defines 'read / write' permissions */
      |                     ^~~~~~~~
/home/billy/Arduino/ulisp.cpp/ulisp.cpp.ino:464:22: note: in expansion of macro '__IO'
  464 |   uint16_t data = (*(__IO uint16*)((*addr) + Eeprom));
      |                      ^~~~
ulisp.cpp:464:22: error: expected ')' before 'volatile'
  464 |   uint16_t data = (*(__IO uint16*)((*addr) + Eeprom));
      |                     ~^
      |                      )
ulisp.cpp:464:54: error: expected ')' before ';' token
  464 |   uint16_t data = (*(__IO uint16*)((*addr) + Eeprom));
      |                   ~                                  ^
      |                                                      )
/home/billy/Arduino/ulisp.cpp/ulisp.cpp.ino: In function 'object* fn_pinmode(object*, object*)':
ulisp.cpp:2880:17: error: 'WiringPinMode' was not declared in this scope
 2880 |   pinMode(pin, (WiringPinMode)pm);
      |                 ^~~~~~~~~~~~~
exit status 1
'FLASH_Unlock' was not declared in this scope; did you mean 'HAL_FLASH_Unlock'?

[technoblogy]

The latest version of uLisp for the Blue Pill and Maple Mini is 3.0b. Are you using Roger Clark's core?

[chrysophylax]

Yes, indeed, I was trying 3.0b but using the STM32 official core, not Roger Clark's. To clarify: I meant which version of the STM32 official Arduino core was last known 'working' :-)

[technoblogy]

The official core doesn't have the FLASH EEPROM emulation.

[chrysophylax]

Oh, that would make sense then. I was going off the website examples that mention both official and RogerClark cores working. Thanks for the clarification!

…

On Wed, Dec 2, 2020, 11:04 David Johnson-Davies ***@***.***> wrote: The official core doesn't have the FLASH EEPROM emulation. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACQWDX5HAGI4DKDMQLAHURLSSYGLRANCNFSM4UJ4CMZA> .

[chrysophylax]

Oh, that would make sense then. I was going off the website examples that mention both official and RogerClark cores working.

Thanks for the clarification!

[technoblogy]

I was going off the website examples that mention both official and RogerClark cores working.

You're right! I must have written that before I made (save-image) work with emulated EEPROM.

I think if you say you want to use an SD Card for saving images, by uncommenting:

#define sdcardsupport

then it may work on the official core. Let me know and I'll update the documentation.

[chrysophylax]

No progress sadly with enabling sdcardsupport. I will switch to Roger's core for now but comments on the forums for stm32duino seem to mean that it's a legacy product already.

Only the Official Core from STM is supported. Roger's core is in long-term (limited changes) mode.

I think one might be able to flash the memory using the more direct HAL library calls for the stm32f103 official core but you have to deal with it in pages, not EEPROM style ARMmbed/mbed-os#6380 (an example of calls to HAL_FLASHEx_Erase / cache invalidation)

[technoblogy]

I tried implementing the HAL library calls, but it turned out to be a lot of work.

Another workaround would be to stick with the official core, but comment out the body of saveimage() and loadimage() so the errors go away.

Regards,
David

[chrysophylax]

Hmm,

I tried commenting out the respective bodies of saveimage() and loadimage() but that just gave me a lot of further errors with various flash write int/16 functions with -fpermissive and ISO C++ forbidding the use of no type name. I commented out the bodies of those functions too and now I am left with

/home/billy/Arduino/ulisp-nosaves/ulisp-nosaves.ino: In function 'object* fn_pinmode(object*, object*)':
ulisp-nosaves:2882:17: error: 'WiringPinMode' was not declared in this scope
   pinMode(pin, (WiringPinMode)pm);
                 ^~~~~~~~~~~~~
/home/billy/Arduino/ulisp-nosaves/ulisp-nosaves.ino:2882:17: note: suggested alternative: 'PinMode'
   pinMode(pin, (WiringPinMode)pm);
                 ^~~~~~~~~~~~~
                 PinMode
exit status 1
'WiringPinMode' was not declared in this scope

as the only remaining errors.

Thanks for your patience!
Billy

[chrysophylax]

I put a gist up https://gist.github.com/chrysophylax/ad9d87db920eb7990b259f487da1b25d

[chrysophylax]

Turns out casting pm to (uint32_t) instead makes it compile! Time to test it out.

[chrysophylax]

Hurrah.

I updated the gist.

[chrysophylax]

I just ran https://github.com/stm32duino/STM32Examples/blob/master/examples/NonReg/BufferedEEPROM/BufferedEEPROM.ino
on my F103 and it works fine. Could this be used instead to write saveimage/loadimage?

[chrysophylax]

Should be similar to the ARM32 version I see actually, maybe it'd be worth adding a #define officialstm32 and some #if defined checks in FlashWriteInt to it looks more like

void FlashWriteInt (uint32_t *addr, int data) {
#if defined(officialstm32)
  FlashWriteByte(addr, data & 0xFF); FlashWriteByte(addr, data>>8 & 0xFF);
  FlashWriteByte(addr, data>>16 & 0xFF); FlashWriteByte(addr, data>>24 & 0xFF);
#else 
  FlashWrite16(addr, data & 0xFFFF); FlashWrite16(addr, data>>16 & 0xFFFF);
#endif
}

where FlashWriteByte basically invokes

void eeprom_buffered_write_byte(uint32_t pos, uint8_t value);

and saveimage would need a buffer flush at the end (likewise for loadimage, a buffer fill)

#if defined(officialstm32)
	eeprom_buffer_flush(); //buffered API
#endif
  return imagesize; 

I'll try it out tomorrow unless you beat me to it :)