Skip to content

fix(map): clear desktop drawer & list panel from bottom OS taskbar#1060

Merged
escapedcat merged 1 commit into
mainfrom
fix/map-drawer-see-full-profile
Jun 12, 2026
Merged

fix(map): clear desktop drawer & list panel from bottom OS taskbar#1060
escapedcat merged 1 commit into
mainfrom
fix/map-drawer-see-full-profile

Conversation

@escapedcat

@escapedcat escapedcat commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

The desktop merchant drawer and list panel anchored their bottom edge only ~12-16px above the viewport bottom, so on a Windows tablet in PC Mode the OS taskbar covered the bottom of the drawer and the "See full profile" link was never reachable.

Reserve max(3rem, env(safe-area-inset-bottom)) of bottom clearance on both: env() handles notched phones, and the 3rem floor clears the taskbar on Windows, which reports a 0 safe-area inset.

Summary by CodeRabbit

  • Bug Fixes
    • Improved safe-area handling in the merchant drawer and list panel to ensure proper layout positioning on devices with notches or home indicators.

The desktop merchant drawer and list panel anchored their bottom edge only
~12-16px above the viewport bottom, so on a Windows tablet in PC Mode the OS
taskbar covered the bottom of the drawer and the "See full profile" link was
never reachable.

Reserve max(3rem, env(safe-area-inset-bottom)) of bottom clearance on both:
env() handles notched phones, and the 3rem floor clears the taskbar on
Windows, which reports a 0 safe-area inset.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c5fba882-37bd-4806-a3aa-c21270bdc55f

📥 Commits

Reviewing files that changed from the base of the PR and between eb6ca62 and 3bb92da.

📒 Files selected for processing (2)
  • src/routes/map/components/MerchantDrawerDesktop.svelte
  • src/routes/map/components/MerchantListPanel.svelte

📝 Walkthrough

Walkthrough

This PR updates two merchant UI components in the map interface to use CSS environment variables for safe-area-aware bottom clearance. The drawer's max-height and the list panel's bottom offset now adapt dynamically to device safe-area insets instead of using fixed spacing values.

Changes

Safe-area-aware merchant UI positioning

Layer / File(s) Summary
Merchant drawer and list safe-area bottom clearance
src/routes/map/components/MerchantDrawerDesktop.svelte, src/routes/map/components/MerchantListPanel.svelte
MerchantDrawerDesktop max-height calculation updated to reserve 0.75rem plus env(safe-area-inset-bottom) at the bottom; MerchantListPanel bottom offset changed from fixed md:bottom-4 to md:bottom-[max(3rem,env(safe-area-inset-bottom))] to adapt to device bottom safe areas.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • teambtcmap/btcmap.org#1059: Both PRs update layout bottom clearance to be safe-area-aware by switching to env(safe-area-inset-bottom)-based Tailwind expressions (main: merchant drawer/list; retrieved: footer/header/modal and related overlays).

Suggested labels

Review effort 2/5

Suggested reviewers

  • dadofsambonzuki
  • bubelov

Poem

🐰 A drawer learns to respect the safe zone's embrace,
Where notches and islands now find their true place,
With env variables dancing, from bottom to sky,
The merchant list follows—in sync, standing by!
Safe areas respected, the UI's more spry! 🌱

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides context for the issue, explains the solution, and covers technical details. However, it does not follow the repository's template structure with required sections like 'Does this PR address a related issue?', 'Screenshots', and explicit headings. Restructure the description to match the template: add a section addressing related issues, include screenshots showing the fix, and organize content under the template's headings.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: fixing the merchant drawer and list panel positioning to avoid overlap with the OS taskbar on desktop.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/map-drawer-see-full-profile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for btcmap ready!

Name Link
🔨 Latest commit 3bb92da
🔍 Latest deploy log https://app.netlify.com/projects/btcmap/deploys/6a2c1da5278b6f00073c5653
😎 Deploy Preview https://deploy-preview-1060--btcmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 48 (🔴 down 39 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 96 (no change from production)
PWA: 90 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@escapedcat escapedcat merged commit 91d29ed into main Jun 12, 2026
12 checks passed
@escapedcat escapedcat deleted the fix/map-drawer-see-full-profile branch June 12, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant