Skip to content

Commit bf0731d

Browse files
author
jan.nijtmans
committed
Use TCL_SIZE_MODIFIER when appropriate
1 parent 7213582 commit bf0731d

File tree

6 files changed

+22
-10
lines changed

6 files changed

+22
-10
lines changed

generic/itcl.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,11 @@ ITCL_EXTERN int Itcl_SafeInit(Tcl_Interp *interp);
132132
#define ITCL_PRIVATE 3
133133
#define ITCL_DEFAULT_PROTECT 4
134134

135-
#if (TCL_MAJOR_VERSION == 8) && (TCL_MINOR_VERSION < 7) && !defined(Tcl_Size)
135+
#if (TCL_MAJOR_VERSION == 8) && (TCL_MINOR_VERSION < 7)
136+
# if !defined(Tcl_Size)
136137
# define Tcl_Size int
138+
# endif
139+
# define Tcl_ObjCmdProc2 Tcl_ObjCmdProc
137140
#endif
138141

139142
/*

generic/itclClass.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1562,7 +1562,7 @@ ItclClassCreateObject(
15621562
do {
15631563
Tcl_CmdInfo dummy;
15641564

1565-
sprintf(unique,"%.200s%" ITCL_Z_MODIFIER "u", Tcl_GetString(iclsPtr->namePtr),
1565+
sprintf(unique,"%.200s%" TCL_SIZE_MODIFIER "u", Tcl_GetString(iclsPtr->namePtr),
15661566
iclsPtr->unique++);
15671567
unique[0] = tolower(UCHAR(unique[0]));
15681568

generic/itclEnsemble.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -784,7 +784,7 @@ CreateEnsemble(
784784
memset(ensData->parts, 0, ensData->maxParts*sizeof(EnsemblePart*));
785785
Tcl_DStringInit(&buffer);
786786
Tcl_DStringAppend(&buffer, ITCL_COMMANDS_NAMESPACE "::ensembles::", TCL_INDEX_NONE);
787-
sprintf(buf, "%" ITCL_Z_MODIFIER "u", ensData->ensembleId);
787+
sprintf(buf, "%" TCL_SIZE_MODIFIER "u", ensData->ensembleId);
788788
Tcl_DStringAppend(&buffer, buf, TCL_INDEX_NONE);
789789
ensData->nsPtr = Tcl_CreateNamespace(interp, Tcl_DStringValue(&buffer),
790790
ensData, DeleteEnsemble);
@@ -837,7 +837,7 @@ CreateEnsemble(
837837
Tcl_DStringSetLength(&buffer, 0);
838838
Tcl_DStringAppend(&buffer, infoPtr->ensembleInfo->ensembleNsPtr->fullName, TCL_INDEX_NONE);
839839
Tcl_DStringAppend(&buffer, "::subensembles::", TCL_INDEX_NONE);
840-
sprintf(buf, "%" ITCL_Z_MODIFIER "u", parentEnsData->ensembleId);
840+
sprintf(buf, "%" TCL_SIZE_MODIFIER "u", parentEnsData->ensembleId);
841841
Tcl_DStringAppend(&buffer, buf, TCL_INDEX_NONE);
842842
Tcl_DStringAppend(&buffer, "::", 2);
843843
Tcl_DStringAppend(&buffer, ensName, TCL_INDEX_NONE);

generic/itclHelpers.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ ItclCreateArgList(
129129
"\" has argument with no name", NULL);
130130
} else {
131131
char buf[TCL_INTEGER_SPACE];
132-
sprintf(buf, "%" ITCL_Z_MODIFIER "d", i);
132+
sprintf(buf, "%" TCL_SIZE_MODIFIER "d", i);
133133
Tcl_AppendResult(interp, "argument #", buf,
134134
" has no name", NULL);
135135
}

generic/itclInt.h

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,19 @@
8080
# endif
8181
#endif
8282

83-
#if TCL_MAJOR_VERSION == 8
84-
# define ITCL_Z_MODIFIER ""
85-
#else
86-
# define ITCL_Z_MODIFIER TCL_Z_MODIFIER
83+
#if TCL_MAJOR_VERSION == 8 && defined(TCL_MINOR_VERSION) && TCL_MINOR_VERSION < 7
84+
# define Tcl_MethodType2 Tcl_MethodType
85+
# define Tcl_MethodCallProc2 Tcl_MethodCallProc
86+
# define Tcl_NewMethod2 Tcl_NewMethod
87+
# define Tcl_CreateObjCommand2 Tcl_CreateObjCommand
88+
# define Tcl_NRCallObjProc2 Tcl_NRCallObjProc
89+
# define Tcl_NRCreateCommand2 Tcl_NRCreateCommand
90+
# define objProc2 objProc
91+
# define objClientData2 objClientData
92+
# define Tcl_NewInstanceMethod2 Tcl_NewInstanceMethod
93+
# define TclGetObjInterpProc2 TclGetObjInterpProc
94+
# define TCL_OO_METHOD_VERSION_2 TCL_OO_METHOD_VERSION_CURRENT
95+
# define TCL_SIZE_MODIFIER ""
8796
#endif
8897

8998
/*

generic/itclObject.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ ItclCreateObject(
404404
do {
405405
Tcl_CmdInfo dummy;
406406

407-
sprintf(unique,"%.200s_%" ITCL_Z_MODIFIER "u", name, iclsPtr->unique++);
407+
sprintf(unique,"%.200s_%" TCL_SIZE_MODIFIER "u", name, iclsPtr->unique++);
408408
unique[0] = tolower(UCHAR(unique[0]));
409409

410410
Tcl_DStringSetLength(&buffer, 0);

0 commit comments

Comments
 (0)