change defaults in python script args

Author: Hoodie-Huuuuu

.github/workflows/test.yml

@@ -6,10 +6,6 @@ on:
 env:
   GIT_CONFIG_GLOBAL: "/root/.gitconfig" # fix path in container (https://github.com/actions/runner/issues/2033)
 
-defaults:
-  run:
-    shell: "bash"
-
 jobs:
 
   ### LINT ###
@@ -91,9 +87,7 @@ jobs:
       - name: "Make comparison report"
         run: |
           python ./build/ci/compare_benchmarks.py \
-            --alert-threshold 7 \
-            --aggregation mean \
-            --sha-file "$BENCH_MASTER_SHA_FILE_PATH" \
+            --old-commit-sha-path "$BENCH_MASTER_SHA_FILE_PATH" \
             "$BENCH_MASTER_FILE_PATH" \
             benchmark.txt \
             >> performance-report.md

build/ci/compare_benchmarks.py

@@ -201,14 +201,14 @@ def build_report_header(old_file, sha_file: str) -> str:
 def main():
     parser = argparse.ArgumentParser(description="Compare go test -bench results in markdown format")
     parser.add_argument(
-        "--alert-threshold", type=float, default=5,
+        "--alert-threshold", type=float, default=7,
         help="Percent change threshold for adding emoji alerts"
     )
     parser.add_argument(
         "--aggregation", choices=["mean", "median"], default="mean",
         help="Aggregation method for multiple runs of the same benchmark"
     )
-    parser.add_argument("--sha-file", help="Path to file with sha commit of the old benchmark")
+    parser.add_argument("--old-commit-sha-path", help="Path to file with sha commit of the old benchmark")
     parser.add_argument("old_file", help="Path to old benchmark results file", nargs='?', default="")
     parser.add_argument("new_file", help="Path to new benchmark results file")
     args = parser.parse_args()
@@ -219,7 +219,7 @@ def main():
 
     new_metrics = aggregate_results(parse_metrics_file(args.new_file), args.aggregation)
 
-    print(build_report_header(args.old_file, args.sha_file))
+    print(build_report_header(args.old_file, args.old_commit_sha_path))
     print(compare_benchmarks_df(old_metrics, new_metrics, alert_threshold=args.alert_threshold))