Skip to content

unnecessary decodeURIComponent? #1

@philfreo

Description

@philfreo

this line - https://github.com/tadruj/s3upload-coffee-javascript/blob/master/s3upload.coffee#L61
seems like it has an unnecessary decodeURIComponent
obviously i can make it work by making my server urlencode the value before json encoding it... but what's the point, if it's just going to be decoded?

if you removed it then you could also simplify your tutorial (i'm assuming the tutorial is yours, but maybe not) example from:
signed_request: CGI::escape("#{S3_URL}#{S3_BUCKET_NAME}/#{objectName}?AWSAccessKeyId=#{S3_ACCESS_KEY}&Expires=#{expires}&Signature=#{sig}"),
to
signed_request: "#{S3_URL}#{S3_BUCKET_NAME}/#{objectName}?AWSAccessKeyId=#{S3_ACCESS_KEY}&Expires=#{expires}&Signature=#{sig}",

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions