fix(lint): solve linting issues

.github/workflows/ci-provider-docs.yaml

@@ -7,72 +7,28 @@ on:
 
 env:
   TERRAFORM_VERSION: "0.14.8"
-  GO_VERSION: "^1.17"
 
 jobs:
-  go_build:
+  ci-provider-docs:
     name: go build
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - uses: actions/cache@v4
-      continue-on-error: true
-      id: cache-terraform-plugin-dir
-      timeout-minutes: 2
-      with:
-        path: terraform-plugin-dir
-        key: ${{ runner.os }}-terraform-plugin-dir-${{ hashFiles('go.sum') }}-${{ hashFiles('sysdig/**') }}
-    - if: steps.cache-terraform-plugin-dir.outputs.cache-hit != 'true' || steps.cache-terraform-plugin-dir.outcome == 'failure'
-      uses: actions/setup-go@v3
-      with:
-        go-version: ${{ env.GO_VERSION }}
-        check-latest: true
-        cache: true
-    # See also: https://github.com/actions/setup-go/issues/54
-    - if: steps.cache-terraform-plugin-dir.outputs.cache-hit != 'true' || steps.cache-terraform-plugin-dir.outcome == 'failure'
-      name: go env
-      run: |
-        echo "GOCACHE=$(go env GOCACHE)" >> $GITHUB_ENV
-    - if: steps.cache-terraform-plugin-dir.outputs.cache-hit != 'true' || steps.cache-terraform-plugin-dir.outcome == 'failure'
-      uses: actions/cache@v4
-      with:
-        path: ${{ env.GOCACHE }}
-        key: ${{ runner.os }}-GOCACHE-${{ hashFiles('go.sum') }}-${{ hashFiles('sysdig/**') }}
-    - if: steps.cache-terraform-plugin-dir.outputs.cache-hit != 'true' || steps.cache-terraform-plugin-dir.outcome == 'failure'
-      uses: actions/cache@v4
+    - uses: actions/checkout@v4
+
+    - name: Set up Go
+      uses: actions/setup-go@v5
       with:
-        path: ~/go/pkg/mod
-        key: ${{ runner.os }}-go-pkg-mod-${{ hashFiles('go.sum') }}
-    - if: steps.cache-terraform-plugin-dir.outputs.cache-hit != 'true' || steps.cache-terraform-plugin-dir.outcome == 'failure'
-      name: go build
+        go-version-file: go.mod
+
+    - name: go build
       run: go build -o terraform-plugin-dir/registry.terraform.io/sysdiglabs/sysdig/99.99.99/$(go env GOOS)_$(go env GOARCH)/terraform-provider-sysdig .
 
-  terraform_providers_schema:
-    name: terraform providers schema
-    needs: [ go_build ]
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v2
-    - uses: actions/cache@v4
-      continue-on-error: true
-      id: cache-terraform-providers-schema
-      timeout-minutes: 2
-      with:
-        path: terraform-providers-schema
-        key: ${{ runner.os }}-terraform-providers-schema-${{ hashFiles('go.sum') }}-${{ hashFiles('sysdig/**') }}
-    - if: steps.cache-terraform-providers-schema.outputs.cache-hit != 'true' || steps.cache-terraform-providers-schema.outcome == 'failure'
-      uses: actions/cache@v4
-      timeout-minutes: 2
-      with:
-        path: terraform-plugin-dir
-        key: ${{ runner.os }}-terraform-plugin-dir-${{ hashFiles('go.sum') }}-${{ hashFiles('sysdig/**') }}
-    - if: steps.cache-terraform-providers-schema.outputs.cache-hit != 'true' || steps.cache-terraform-providers-schema.outcome == 'failure'
-      uses: hashicorp/setup-terraform@v1
+    - uses: hashicorp/setup-terraform@v1
       with:
         terraform_version: ${{ env.TERRAFORM_VERSION }}
         terraform_wrapper: false
-    - if: steps.cache-terraform-providers-schema.outputs.cache-hit != 'true' || steps.cache-terraform-providers-schema.outcome == 'failure'
-      name: terraform init
+
+    - name: terraform init
       run: |
         # We need a file to initialize the provider
         cat <<EOF > main.tf
@@ -81,34 +37,14 @@ jobs:
         }
         EOF
         terraform init -plugin-dir terraform-plugin-dir
-    - if: steps.cache-terraform-providers-schema.outputs.cache-hit != 'true' || steps.cache-terraform-providers-schema.outcome == 'failure'
-      name: terraform providers schema
+
+    - name: terraform providers schema
       run: |
-        mkdir terraform-providers-schema
+        mkdir -p terraform-providers-schema
         terraform providers schema -json > terraform-providers-schema/schema.json
 
-  tfproviderdocs:
-    needs: [ terraform_providers_schema ]
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v2
-    - uses: actions/setup-go@v3
-      with:
-        go-version: ${{ env.GO_VERSION }}
-        check-latest: true
-        cache: true
-    - uses: actions/cache@v4
-      continue-on-error: true
-      timeout-minutes: 2
-      with:
-        path: ~/go/pkg/mod
-        key: ${{ runner.os }}-go-pkg-mod-${{ hashFiles('go.sum') }}
     - run: cd /tmp && go install github.com/bflad/tfproviderdocs@latest
-    - uses: actions/cache@v4
-      timeout-minutes: 2
-      with:
-        path: terraform-providers-schema
-        key: ${{ runner.os }}-terraform-providers-schema-${{ hashFiles('go.sum') }}-${{ hashFiles('sysdig/**') }}
+
     - name: tfproviderdocs check
       run: |
         tfproviderdocs check \

.github/workflows/ci-scheduled-tests.yml

@@ -5,9 +5,6 @@ on:
     - cron: "0 11 * * *"
   workflow_dispatch:
 
-env:
-  GO_VERSION: "^1.19"         # any 1.x version, see go.mod file for minimum
-
 jobs:
   test:
     name: Test

.github/workflows/ci-master.yml → .github/workflows/ci.yml

@@ -4,9 +4,9 @@ on:
   push:
     branches:
       - master
-
-env:
-  GO_VERSION: "^1.17"
+  pull_request:
+    branches:
+      - master
 
 jobs:
   build-multiarch:
@@ -41,14 +41,12 @@ jobs:
             arch: amd64
     steps:
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
-          check-latest: true
-          cache: true
+          go-version-file: go.mod
 
       - name: Build project
         run: GOOS=${{ matrix.os }} GOARCH=${{ matrix.arch }} go build -o terraform-provider-sysdig

.github/workflows/codeql-analysis.yml

@@ -30,7 +30,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       with:
         # We must fetch at least the immediate parents so that if this is
         # a pull request then we can checkout the head.

.github/workflows/issues-slack-notify.yml

@@ -7,7 +7,7 @@ jobs:
     name: Slack Notification
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Slack Notification
         uses: rtCamp/action-slack-notify@v2
         env:
@@ -23,4 +23,4 @@ jobs:
           status: ${{ job.status }}
           fields: message,author,ref
         env:
-          SLACK_WEBHOOK_URL: {{ secrets.SLACK_WEBHOOK }}
+          SLACK_WEBHOOK_URL: "{{ secrets.SLACK_WEBHOOK }}"

.github/workflows/release.yml

@@ -15,29 +15,28 @@ on:
     tags:
       - 'v*'
 
-env:
-  GO_VERSION: "^1.19"         # any 1.x version, see go.mod file for minimum
-
 jobs:
   goreleaser:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
-      - name: Unshallow
-        run: git fetch --prune --unshallow
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          fetch-tags: true
+
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
-          check-latest: true
-          cache: true
+          go-version-file: go.mod
+
       - name: Import GPG key
         id: import_gpg
         uses: paultyng/[email protected]
         env:
           GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
           PASSPHRASE: ${{ secrets.PASSPHRASE }}
+
       - name: Run GoReleaser
         uses: goreleaser/goreleaser-action@v6
         with:

.github/workflows/test.yml

@@ -10,10 +10,10 @@ jobs:
 
     steps:
       - name: Check out code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Lint
-        uses: golangci/golangci-lint-action@v2
+        uses: golangci/golangci-lint-action@v8
         with:
           args: --timeout 30m --build-tags unit,tf_acc_sysdig_monitor,tf_acc_sysdig_secure,tf_acc_ibm_monitor,tf_acc_ibm_secure
 
@@ -23,14 +23,12 @@ jobs:
 
     steps:
       - name: Check out code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
-          check-latest: true
-          cache: true
+          go-version-file: go.mod
 
       - name: Test
         run: make test
@@ -42,14 +40,12 @@ jobs:
 
     steps:
       - name: Check out code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
-          check-latest: true
-          cache: true
+          go-version-file: go.mod
 
       - name: Test
         run: make testacc
@@ -65,14 +61,12 @@ jobs:
 
     steps:
       - name: Check out code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
-          check-latest: true
-          cache: true
+          go-version-file: go.mod
 
       - name: Test
         run: make testacc
@@ -88,14 +82,12 @@ jobs:
 
     steps:
       - name: Check out code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
-          check-latest: true
-          cache: true
+          go-version-file: go.mod
 
       - name: Test
         run: make testacc
@@ -114,14 +106,12 @@ jobs:
 
     steps:
       - name: Check out code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: ${{ env.GO_VERSION }}
-          check-latest: true
-          cache: true
+          go-version-file: go.mod
 
       - name: Test
         run: make testacc

.gitignore

@@ -3,6 +3,7 @@
 .DS_Store
 .envrc
 .env
+.direnv/
 example.tf
 terraform.tfplan
 terraform.tfstate