Skip to content

Not compatible with Oauth 2.0.10 #43

@yknx4

Description

@yknx4

Following the issue in the oauth repo.

There was a breaking change in which you cant access Oauth2 responses by symbol anymore and it breaks the domain verifier lib/omniauth/microsoft_graph/domain_verifier.rb:79

since the code is doing this

def get_jwks(oidc_config)
        # Depending on the tenant, the JWKS endpoint might be different. We need to
        # consider both the JWKS from the OIDC configuration and the common JWKS endpoint.
        oidc_config_jwk_keys = access_token.get(oidc_config['jwks_uri']).parsed[:keys]
        common_jwk_keys = access_token.get(COMMON_JWKS_URL).parsed[:keys]
        JWT::JWK::Set.new(oidc_config_jwk_keys + common_jwk_keys)
      end

but in the new version it needs to be this

def get_jwks(oidc_config)
        # Depending on the tenant, the JWKS endpoint might be different. We need to
        # consider both the JWKS from the OIDC configuration and the common JWKS endpoint.
        oidc_config_jwk_keys = access_token.get(oidc_config['jwks_uri']).parsed["keys"]
        common_jwk_keys = access_token.get(COMMON_JWKS_URL).parsed["keys"]
        JWT::JWK::Set.new(oidc_config_jwk_keys + common_jwk_keys)
      end

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions