[Bug]: Not always using unique onchain receive address

[catch-21]

Describe the bug

My wallet has not always been using a new unique address for each onchain receive. The latest transaction I took is f23b28ed8e8d4faf942e37824994818163cf4aa7017ea6592d4e3e88fd36d461 and that is to address bc1qqraqjlu9wgxsm8fsf4n8anhyzlkfap0f7eefca, which currently has 11 transactions over the past 3 months. When I go to receive again the same address is suggested.

This was once also the case for bc1q7t9a52ygc8yucya7zm0ypyu4ys3sgay9pq2ecc

Reproduce

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Screenshots / Recording

Operating system

Android 13 TKQ1.221114.001

Bitkit version

v128

Log output

No response

[limpbrains]

Do you still have this issue? It might be fixed in #2210

[pwltr]

Looks like the onchain wallet is not refreshed somewhere:

1. Create new wallet
2. Receive onchain tx
3. Open Receive again, check address

Simulator.Screen.Recording.-.iPhone.15.-.2024-10-02.at.12.23.11.mp4

Then if you pull to refresh you'll get a new address.

[catch-21]

I haven't seen this recently with receive address, but we have seen change address reuse in testing session.
I hope that those are both the same cause that Phil suggested.

[JeanlChristophe]

@catch-21 can you test it again in order to see if Ivan need to spend time on it, please?

[pwltr]

Can easily reproduce this with a new wallet:

1. Create new wallet
2. Receive onchain tx (don't mine block)
3. Open Receive again, check address
4. Also observe no activity

Simulator.Screen.Recording.-.iPhone.15.-.2024-11-07.at.15.40.21.mp4

Feels like this should be handled in beignet but fixed here in Bitkit for now.

[catch-21]

Tested on 1.0.7 (139) 3b9a833 and (141) 97851ff using regtest wallet
My wallet still appears to have got stuck reusing the same address. Note that none of these transactions in the video have confirmed.

Screen-2024-12-03-100206.mp4

... although, after tx confirm the address persists still:

Screen-2024-12-03-101012.mp4

In case it is in any way useful: bitkit_ldk_logs_1733221273874.zip