chore: fixes code smells (#572)

Author: petruki

npm-shrinkwrap.json

@@ -52,10 +52,10 @@
     "jsonwebtoken": "^9.0.2",
     "moment": "^2.30.1",
     "mongodb": "^6.20.0",
-    "mongoose": "^8.18.2",
+    "mongoose": "^8.19.0",
     "passport": "^0.7.0",
     "@node-saml/passport-saml": "^5.1.0",
-    "pino": "^9.11.0",
+    "pino": "^9.13.0",
     "pino-pretty": "^13.1.1",
     "swagger-ui-express": "^5.0.1",
     "switcher-client": "^4.4.1",
@@ -64,7 +64,7 @@
   "devDependencies": {
     "env-cmd": "^11.0.0",
     "eslint": "^9.36.0",
-    "jest": "^30.1.3",
+    "jest": "^30.2.0",
     "jest-sonar-reporter": "^2.0.0",
     "node-notifier": "^10.0.1",
     "nodemon": "^3.1.10",

package.json

@@ -26,10 +26,10 @@ export async function resolvePermission(args, admin) {
         for (const action_perm of args.actions) {
             try {
                 await verifyOwnership(admin, element, args.domain, action_perm, args.router, false, args.environment);
-                result[result.length - 1].permissions.push({ action: action_perm.toString(), result: 'ok' });
+                result.at(-1).permissions.push({ action: action_perm.toString(), result: 'ok' });
             } catch (e) {
                 Logger.debug('resolvePermission', e);
-                result[result.length - 1].permissions.push({ action: action_perm.toString(), result: 'nok' });
+                result.at(-1).permissions.push({ action: action_perm.toString(), result: 'nok' });
             }
         }
     }
@@ -50,5 +50,5 @@ const getElements = async (domain, parent, router) => {
         return getConfigs({ domain, group: parent }, true);
     }
 
-    return Promise.resolve([]);
+    return [];
 };

src/aggregator/permission-resolvers.js

@@ -13,12 +13,12 @@ export const resolveConfigByKey = async (domain, key) => Config.findOne({ domain
 export function resolveEnvValue(source, field, keys) {
     const arrValue = [];
 
-    keys.forEach(k => {
+    for (const k of keys) {
         arrValue.push({
             env: k,
             value: source[field][k]
         });
-    });
+    }
 
     return arrValue;
 }

src/aggregator/resolvers.js

@@ -1,6 +1,6 @@
-import https from 'https';
-import http from 'http';
-import fs from 'fs';
+import https from 'node:https';
+import http from 'node:http';
+import fs from 'node:fs';
 import Logger from './helpers/logger.js';
 
 export const createServer = (app) => {

src/app-server.js

@@ -1,5 +1,5 @@
 import axios from 'axios';
-import https from 'https';
+import https from 'node:https';
 import jwt from 'jsonwebtoken';
 
 const agent = (url) => {

src/external/gitops.js

@@ -10,9 +10,9 @@ const PATTERN_ALPHANUMERIC = /^[a-zA-Z0-9_-]*$/;
 
 export async function checkEnvironmentStatusRemoval(domainId, environmentName, strategy = false) {
     const environment = await getEnvironments({ domain: domainId }, ['_id', 'name']);
-    const isValidOperation = environment.filter((e) => 
+    const isValidOperation = environment.some((e) => 
         e.name === environmentName && 
-        !strategy ? environmentName !== EnvType.DEFAULT : strategy).length > 0;
+        !strategy ? environmentName !== EnvType.DEFAULT : strategy);
 
     if (!isValidOperation) {
         throw new BadRequestError('Invalid environment');
@@ -32,33 +32,33 @@ export function containsValue(arr, value) {
 }
 
 export function formatInput(input, 
-    options = { 
-        toUpper: false, 
-        toLower: false, 
-        autoUnderscore: false, 
-        allowSpace: false 
-    }) {
+    {
+        toUpper = false,
+        toLower = false,
+        autoUnderscore = false,
+        allowSpace = false
+    } = {}) {
 
     let regexStr;
-    if (options.autoUnderscore) {
+    if (autoUnderscore) {
         regexStr = PATTERN_ALPHANUMERIC_SPACE;
     } else {
-        regexStr = options.allowSpace ? PATTERN_ALPHANUMERIC_SPACE : PATTERN_ALPHANUMERIC;
+        regexStr = allowSpace ? PATTERN_ALPHANUMERIC_SPACE : PATTERN_ALPHANUMERIC;
     }
 
     const regex = new RegExp(regexStr);
     if (!regex.test(input)) {
         throw new Error('Invalid input format. Use only alphanumeric digits.');
     }
 
-    if (options.toUpper) {
+    if (toUpper) {
         input = input.toUpperCase();
-    } else if (options.toLower) {
+    } else if (toLower) {
         input = input.toLowerCase();
     }
 
-    if (options.autoUnderscore) {
-        input = input.replace(/\s/g, '_');
+    if (autoUnderscore) {
+        input = input.replaceAll(' ', '_');
     }
 
     return input.trim();
@@ -76,11 +76,11 @@ export function sortBy(args) {
 }
 
 export function validatePagingArgs(args) {
-    if (args.limit && !Number.isInteger(parseInt(args.limit)) || parseInt(args.limit) < 1) {
+    if (args.limit && !Number.isInteger(Number.parseInt(args.limit)) || Number.parseInt(args.limit) < 1) {
         return false;
     }
 
-    if (args.skip && !Number.isInteger(parseInt(args.skip)) || parseInt(args.skip) < 0) {
+    if (args.skip && !Number.isInteger(Number.parseInt(args.skip)) || Number.parseInt(args.skip) < 0) {
         return false;
     }
 

src/helpers/index.js

@@ -83,10 +83,10 @@ function validateChangesContent(changes) {
     for (const change of changes) {
         if (CONTENT_TYPE_ARRAY.includes(change.diff)) {
             if (!Array.isArray(change.content)) {
-                throw new Error('Request has invalid content type [object]');
+                throw new TypeError('Request has invalid content type [object]');
             }
         } else if (Array.isArray(change.content)) {
-            throw new Error('Request has invalid content type [array]');
+            throw new TypeError('Request has invalid content type [array]');
         }
     }
 }

src/middleware/gitops.js

@@ -7,7 +7,7 @@ const ERROR_MESSAGE = {
 
 const getMaxRate = (rate_limit) => {
 	if (rate_limit === 0) {
-		return parseInt(DEFAULT_RATE_LIMIT);
+		return Number.parseInt(DEFAULT_RATE_LIMIT);
 	}
 
 	return rate_limit;
@@ -17,7 +17,7 @@ export const DEFAULT_RATE_LIMIT = 1000;
 
 export const defaultLimiter = rateLimit({
 	windowMs: DEFAULT_WINDOWMS,
-	limit: getMaxRate(parseInt(process.env.MAX_REQUEST_PER_MINUTE)),
+	limit: getMaxRate(Number.parseInt(process.env.MAX_REQUEST_PER_MINUTE)),
 	skip: (request) => request.rate_limit === 0,
 	standardHeaders: 'draft-7',
 	legacyHeaders: false,

src/middleware/limiter.js

@@ -6,7 +6,7 @@ export async function checkEnvironmentStatusChange(args, domain, field) {
     const environment = await getEnvironments({ domain }, ['_id', 'name']);
     const updates = Object.keys(field || args);
     const isValidOperation = updates.every((update) => {
-        return environment.filter((e) => e.name === update).length > 0;
+        return environment.some((e) => e.name === update);
     });
 
     if (!isValidOperation) {