Skip to content

[JExtract/JNI] Omit unsupported types instead of crashing #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 14, 2025
Merged

[JExtract/JNI] Omit unsupported types instead of crashing #313

merged 5 commits into from
Jul 14, 2025

Conversation

madsodgaard
Copy link
Contributor

Omits any unsupported types such as UInt8 instead of crashing the generation.

@ktoso
Copy link
Collaborator

ktoso commented Jul 13, 2025

Minor log level nitpick.

Does the FFM mode already do the same? Can we add the same “test” (just a decl we ignore) in FFM?

@madsodgaard
Copy link
Contributor Author

@ktoso Yes FFM should also ignore any unsupported types, but I also added a unsupported type to the FFM sample app.

@ktoso ktoso merged commit 9c0d7eb into swiftlang:main Jul 14, 2025
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsodgaard @ktoso