Skip to content

Commit 3c3e0c2

Browse files
committed
small cleanups
1 parent e64814d commit 3c3e0c2

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

.github/workflows/pull_request.yml

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,14 @@ jobs:
3131
- uses: actions/checkout@v4
3232
- name: Prepare CI Environment
3333
uses: ./.github/actions/prepare_env
34-
- name: Gradle :SwiftKit:build
35-
run: ./gradlew build -x test
36-
- name: Gradle :SwiftKit:check
37-
run: ./gradlew :SwiftKit:check --info
34+
- name: Gradle :SwiftKitCore:build
35+
run: ./gradlew :SwiftKitCore:build -x test
36+
- name: Gradle :SwiftKitCore:check
37+
run: ./gradlew :SwiftKitCore:check --info
38+
- name: Gradle :SwiftKitFFM:build
39+
run: ./gradlew :SwiftKitFFM:build -x test
40+
- name: Gradle :SwiftKitFFM:check
41+
run: ./gradlew :SwiftKitFFM:check --info
3842

3943
test-java-macos:
4044
name: Test (Java) (${{ matrix.os_version }} swift:${{ matrix.swift_version }} jdk:${{matrix.jdk_vendor}})
@@ -51,10 +55,14 @@ jobs:
5155
- uses: actions/checkout@v4
5256
- name: Prepare CI Environment
5357
uses: ./.github/actions/prepare_env
54-
- name: Gradle :SwiftKit:build
55-
run: ./gradlew build -x test
56-
- name: Gradle :SwiftKit:check
57-
run: ./gradlew :SwiftKit:check --debug
58+
- name: Gradle :SwiftKitCore:build
59+
run: ./gradlew :SwiftKitCore:build -x test
60+
- name: Gradle :SwiftKitCore:check
61+
run: ./gradlew :SwiftKitCore:check --debug
62+
- name: Gradle :SwiftKitFFM:build
63+
run: ./gradlew :SwiftKitFFM:build -x test
64+
- name: Gradle :SwiftKitFFM:check
65+
run: ./gradlew :SwiftKitFFM:check --debug
5866

5967
benchmark-java:
6068
name: Benchmark (JMH) (${{ matrix.os_version }} swift:${{ matrix.swift_version }} jdk:${{matrix.jdk_vendor}})

Samples/SwiftAndJavaJarSampleLib/src/jmh/java/org/swift/swiftkit/JavaToSwiftBenchmark.java renamed to Samples/SwiftAndJavaJarSampleLib/src/jmh/java/org/swift/swiftkit/ffm/JavaToSwiftBenchmark.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
//
1313
//===----------------------------------------------------------------------===//
1414

15-
package org.swift.swiftkitffm;
15+
package org.swift.swiftkit.ffm;
1616

1717
import java.util.concurrent.TimeUnit;
1818

Samples/SwiftAndJavaJarSampleLib/src/main/java/com/example/swift/HelloJava2Swift.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
// Import swift-extract generated sources
1818

1919
// Import javakit/swiftkit support libraries
20+
import org.swift.swiftkit.core.SwiftLibraries;
2021
import org.swift.swiftkit.ffm.AllocatingSwiftArena;
2122
import org.swift.swiftkit.ffm.SwiftRuntime;
22-
import org.swift.swiftkit.core.SwiftLibraries;
2323

2424
public class HelloJava2Swift {
2525

SwiftKitCore/src/main/java/org/swift/swiftkit/core/SwiftArena.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,24 +22,16 @@
2222
* associated owner thread such as {@link ClosableSwiftArena#close()}.
2323
*/
2424
public interface SwiftArena {
25-
26-
// static ClosableSwiftArena ofConfined() {
27-
// return new ConfinedSwiftMemorySession(Thread.currentThread());
28-
// }
29-
3025
/**
3126
* Register a Swift object.
3227
* Its memory should be considered managed by this arena, and be destroyed when the arena is closed.
3328
*/
3429
void register(SwiftInstance instance);
35-
3630
}
3731

3832
/**
3933
* Represents a list of resources that need a cleanup, e.g. allocated classes/structs.
4034
*/
4135
interface SwiftResourceList {
42-
4336
void runCleanup();
44-
4537
}

0 commit comments

Comments
 (0)