You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's referenced in the WiX sources but doesn't actually get installed on the system. Does WiX not error out if it references a file that doesn't exist when building the installer?
Oh, looks like you fixed clang in fe35b36, but that's not in the 6.0 branch. I'll update the title to reflect that this is only an issue for docc, then.
What's the docc usability issue you were referencing above?
changed the title [-]features.json is missing from Windows installer for clang and docc[/-][+]features.json is missing from Windows installer for docc[/+]on Sep 9, 2024
DocC cannot generate the documentation on Windows due to the use of : in the filenames. There is an existing PR (swiftlang/swift-docc#668) that adjusts that, but I think that there is still lack of clarity on how to migrate to that.
Yeah, I suppose that we could start building it. The one issue is the build times - I think that using CMake resulted in a 7% build time improvement as well as alleviated some bloat due to being able to do dynamic linking against other toolchain components.
Activity
compnerd commentedon Sep 7, 2024
DocC currently isn't usable on windows due to the missing pending change (CC: @FranzBusch). I'm happy to add the features.json for clang though.
compnerd commentedon Sep 9, 2024
https://github.com/swiftlang/swift-installer-scripts/blob/main/platforms/Windows/bld/bld.wxs#L158-L162
It seems that the clang features.json is already present. @jakepetroules is there something that I'm missing here?
jakepetroules commentedon Sep 9, 2024
It's referenced in the WiX sources but doesn't actually get installed on the system. Does WiX not error out if it references a file that doesn't exist when building the installer?
compnerd commentedon Sep 9, 2024
Yes, if the file is missing the installer will fail to build.
jakepetroules commentedon Sep 9, 2024
Oh, looks like you fixed clang in fe35b36, but that's not in the 6.0 branch. I'll update the title to reflect that this is only an issue for docc, then.
What's the docc usability issue you were referencing above?
[-]features.json is missing from Windows installer for clang and docc[/-][+]features.json is missing from Windows installer for docc[/+]compnerd commentedon Sep 9, 2024
DocC cannot generate the documentation on Windows due to the use of
:
in the filenames. There is an existing PR (swiftlang/swift-docc#668) that adjusts that, but I think that there is still lack of clarity on how to migrate to that.jakepetroules commentedon Sep 9, 2024
Thanks for the reference. I think those two issues could be resolved in parallel, though.
compnerd commentedon Sep 9, 2024
Yeah, I suppose that we could start building it. The one issue is the build times - I think that using CMake resulted in a 7% build time improvement as well as alleviated some bloat due to being able to do dynamic linking against other toolchain components.
jakepetroules commentedon Sep 13, 2024
To be clear, we are currently shipping docc.exe as part of the Swift Windows installer already. Just the features.json is missing.
compnerd commentedon Sep 13, 2024
Interesting, I don't remember getting that enabled, but that is great!
jakepetroules commentedon Sep 16, 2024
Oh, you may be right. I remember seeing it in some toolchain build at least, maybe that was an older version and it's since been removed again.