chore(es/transforms): Remove export-default-from benchmark - #12350
chore(es/transforms): Remove export-default-from benchmark#12350Donny/강동윤 (kdy1) wants to merge 2 commits into
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
https://github.com/swc-project/swc/blob/c739ae1e64d59cf27a03a80581939ef97e92a599/crates/swc_ecma_transforms_proposal/Cargo.toml#L44
After deleting this benchmark target, codspeed-criterion-compat remains declared at Cargo.toml:36 even though no source or test in this crate references it. Consequently, crate-level test and check builds still resolve and compile the CodSpeed dependency tree for no benefit; remove that dev-dependency along with the benchmark.
AGENTS.md reference: AGENTS.md:L7-L7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Merging this PR will not alter performance
Comparing 
Footnotes
|
1 participant
Description:
Remove the obsolete export-default-from benchmark and its Cargo bench target registration.
BREAKING CHANGE:
None.
Related issue (if exists):
None.
Validation:
cargo fmt --allcargo test -p swc_ecma_transforms_proposal --test exportcargo clippy -p swc_ecma_transforms_proposal --all-targets -- -D warningscargo test -p swc_ecma_transforms_proposalis blocked by the environment missingmochafor existing decorator fixtures.cargo clippy --all --all-targets -- -D warningsis blocked by the pre-existingswc_native_addon/src/platform/unix.rs:117dead-code warning.