Adding skip_unsettable flag to load method

Author: swansonk14

tap/tap.py

@@ -487,12 +487,17 @@ def save(self, path: str) -> None:
         with open(path, 'w') as f:
             json.dump(self._log_all(), f, indent=4, sort_keys=True, cls=PythonObjectEncoder)
 
-    def load(self, path: str, check_reproducibility: bool = False) -> None:
+    def load(self,
+             path: str,
+             check_reproducibility: bool = False,
+             skip_unsettable: bool = False) -> None:
         """Loads the arguments in JSON format. Note: Due to JSON, tuples are loaded as lists.
 
         :param path: Path to the JSON file where the arguments will be loaded from.
         :param check_reproducibility: When True, raises an error if the loaded reproducibility
                                       information doesn't match the current reproducibility information.
+        :param skip_unsettable: When True, skips attributes that cannot be set in the Tap object,
+                                e.g. properties without setters.
         """
         with open(path) as f:
             args_dict = json.load(f, object_hook=as_python_object)
@@ -528,7 +533,7 @@ def load(self, path: str, check_reproducibility: bool = False) -> None:
                 raise ValueError(f'{no_reproducibility_message}: Uncommitted changes '
                                  f'in current args.')
 
-        self.from_dict(args_dict)
+        self.from_dict(args_dict, skip_unsettable=skip_unsettable)
 
     def __str__(self) -> str:
         """Returns a string representation of self.

tests/test_integration.py

@@ -955,6 +955,45 @@ def add_arguments(self) -> None:
         output = {'e': 7, 'f': {1}, 'd': ('a', 'b'), 'c': True, 'a': 'hi', 'b': 1, 'g': Person('tapper')}
         self.assertEqual(output, new_args.as_dict())
 
+    def test_save_load_property(self):
+        class PropertySaveLoadTap(Tap):
+            a: str = 'hello'
+
+            def __init__(self):
+                super(PropertySaveLoadTap, self).__init__()
+                self._prop1 = 1
+                self._prop2 = 'hi'
+
+            @property
+            def prop1(self):
+                return self._prop1
+
+            @property
+            def prop2(self):
+                return self._prop2
+
+            @prop2.setter
+            def prop2(self, prop2):
+                self._prop2 = prop2
+
+            def process_args(self) -> None:
+                self._prop1 = 2
+                self.prop2 = 'bye'
+
+        args = PropertySaveLoadTap().parse_args([])
+
+        with NamedTemporaryFile() as f:
+            args.save(f.name)
+            new_args = PropertySaveLoadTap()
+
+            with self.assertRaises(AttributeError):
+                new_args.load(f.name)  # because trying to set unsettable prop1
+
+            new_args.load(f.name, skip_unsettable=True)
+
+        output = {'a': 'hello', 'prop1': 1, 'prop2': 'bye'}
+        self.assertEqual(output, new_args.as_dict())
+
 
 class TestDeepCopy(TestCase):
     def test_deep_copy(self):