Linting

Author: svandragt

php-activate.sh

@@ -1,12 +1,14 @@
 #!/usr/bin/env bash
 
 function php-activate {
-    if ! [ -z "$1" ]
+    if [ -n "$1" ]
     then
-        local VERSIONS=$(update-alternatives --query php | grep Alternative | cut -d ' ' -f2 )
-        if echo $VERSIONS | grep -q "$1"
+        local VERSIONS
+        VERSIONS=$(update-alternatives --query php | grep Alternative | cut -d ' ' -f2 )
+        if echo "$VERSIONS" | grep -q "$1"
         then
-            export PHP_PICKED=$(echo "$VERSIONS" | sort | grep "$1" | head -n 1)
+            PHP_PICKED=$(echo "$VERSIONS" | sort | grep "$1" | head -n 1)
+            export PHP_PICKED
             echo "Activated $PHP_PICKED"
         else
             echo "Error: No matching PHP version found. Use one of the following:"
@@ -20,11 +22,10 @@ function php-activate {
         return
     fi
     function php {
-        $PHP_PICKED $@
+        $PHP_PICKED "$@"
     }
-    export -f php
     php --version | grep built
     hash -r
 }
 
-php-activate $1
+php-activate "$1"