chore: Migrated to biome and fixed formatter warnings

Author: matvp91

.github/workflows/build-artisan-binary.yml

@@ -2,6 +2,15 @@
   "editor.tabSize": 2,
   "editor.formatOnSave": true,
   "editor.defaultFormatter": "biomejs.biome",
+  "[javascript]": {
+    "editor.defaultFormatter": "biomejs.biome"
+  },
+  "[typescript]": {
+    "editor.defaultFormatter": "biomejs.biome"
+  },
+  "[typescriptreact]": {
+    "editor.defaultFormatter": "biomejs.biome"
+  },
   "editor.codeActionsOnSave": {
     "source.fixAll.biome": "explicit",
     "source.organizeImports.biome": "explicit"

.github/workflows/lint.yml

@@ -1,4 +1,5 @@
 import { hc } from "hono/client";
+import type { z } from "zod";
 import type { AppType } from "../src";
 import type { assetSchema, groupSchema } from "../src/schemas/assets";
 import type { jobSchema } from "../src/schemas/jobs";
@@ -7,7 +8,6 @@ import type {
   storageItemSchema,
 } from "../src/schemas/storage";
 import type { userSchema } from "../src/schemas/user";
-import type { z } from "zod";
 
 export type Asset = z.infer<typeof assetSchema>;
 
@@ -39,7 +39,7 @@ export function createClient(url: string, token: string | null = null) {
     headers: () => {
       const headers: Record<string, string> = {};
       if (token !== null) {
-        headers["Authorization"] = `Bearer ${token}`;
+        headers.Authorization = `Bearer ${token}`;
       }
       return headers;
     },

.vscode/settings.json

@@ -9,7 +9,8 @@
   },
   "scripts": {
     "dev": "bun --watch --inspect=ws://localhost:6499/sprs-api ./src/index.ts",
-    "build": "bun build ./src/index.ts --target=bun --outdir=./dist && cp -r ./src/db/migrations ./dist"
+    "build": "bun build ./src/index.ts --target=bun --outdir=./dist && cp -r ./src/db/migrations ./dist",
+    "lint": "biome lint --write ./src ./client"
   },
   "devDependencies": {
     "@types/bun": "latest",

apps/api/client/index.ts

@@ -10,5 +10,5 @@ export const db = new Kysely<KyselyDatabase>({
 });
 
 types.setTypeParser(/* INT8_TYPE_ID= */ 20, (val) => {
-  return parseInt(val, 10);
+  return Number.parseInt(val, 10);
 });

apps/api/package.json

@@ -24,13 +24,14 @@ async function migrateToLatest() {
 
   const { error, results } = await migrator.migrateToLatest();
 
-  results?.forEach((it) => {
+  const allResults = results ?? [];
+  for (const it of allResults) {
     if (it.status === "Success") {
       console.log(`Migration "${it.migrationName}" was executed successfully`);
     } else if (it.status === "Error") {
       console.error(`Failed to execute migration "${it.migrationName}"`);
     }
-  });
+  };
 
   if (error) {
     console.error("Failed to migrate");

apps/api/src/db/index.ts

@@ -1,8 +1,7 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
-
 import { sql } from "kysely";
 import type { Kysely } from "kysely";
 
+// biome-ignore lint/suspicious/noExplicitAny: Use any
 export async function up(db: Kysely<any>) {
   await db.schema
     .createTable("users")
@@ -49,6 +48,7 @@ export async function up(db: Kysely<any>) {
     .execute();
 }
 
+// biome-ignore lint/suspicious/noExplicitAny: Use any
 export async function down(db: Kysely<any>) {
   await db.schema.dropTable("users").execute();
   await db.schema.dropTable("groups").execute();

apps/api/src/db/migrate.ts

@@ -1,11 +1,11 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
-
 import type { Kysely } from "kysely";
 
+// biome-ignore lint/suspicious/noExplicitAny: Use any
 export async function up(db: Kysely<any>) {
   await db.schema.alterTable("assets").addColumn("name", "text").execute();
 }
 
+// biome-ignore lint/suspicious/noExplicitAny: Use any
 export async function down(db: Kysely<any>) {
   await db.schema.alterTable("assets").dropColumn("name").execute();
 }

apps/api/src/db/migrations/2024_10_26_init.ts

@@ -7,9 +7,9 @@ import {
   transcodeQueue,
 } from "bolt";
 import { FlowProducer, Job as RawJob } from "bullmq";
+import type { JobNode, JobState, Queue } from "bullmq";
 import { env } from "../env";
 import { isRecordWithNumbers } from "../utils/type-guard";
-import type { JobNode, JobState, Queue } from "bullmq";
 
 const flowProducer = new FlowProducer({
   connection: {
@@ -36,7 +36,7 @@ function findQueueByName(name: string): Queue {
   if (!queue) {
     throw new Error("No queue found.");
   }
-  return queue;
+  return queue as unknown as Queue;
 }
 
 /**
@@ -199,7 +199,8 @@ async function getJobNode(
  * @param job
  * @returns
  */
-async function findRootJob(job?: RawJob): Promise<RawJob | null> {
+async function findRootJob(inputJob?: RawJob): Promise<RawJob | null> {
+  let job = inputJob;
   if (!job) {
     return null;
   }