fix: change Node.all_node_regions to use syn (#1592)

Author: edgurgel

lib/realtime/nodes.ex

@@ -153,9 +153,7 @@ defmodule Realtime.Nodes do
     end
   end
 
-  @all_regions ~w(eu-west-2 us-east-1 us-west-1 ap-southeast-1 ap-southeast-2)
-
   @spec all_node_regions() :: [String.t()]
   @doc "List all the regions where nodes can be launched"
-  def all_node_regions(), do: @all_regions
+  def all_node_regions(), do: :syn.group_names(RegionNodes)
 end

mix.exs

@@ -4,7 +4,7 @@ defmodule Realtime.MixProject do
   def project do
     [
       app: :realtime,
-      version: "2.56.4",
+      version: "2.56.5",
       elixir: "~> 1.18",
       elixirc_paths: elixirc_paths(Mix.env()),
       start_permanent: Mix.env() == :prod,

test/realtime/nodes_test.exs

@@ -20,6 +20,20 @@ defmodule Realtime.NodesTest do
     assert_receive :joined
   end
 
+  describe "all_node_regions/0" do
+    test "returns all regions with nodes" do
+      spawn_fake_node("us-east-1", :node_1)
+      spawn_fake_node("ap-2", :node_2)
+      spawn_fake_node("ap-2", :node_3)
+
+      assert Nodes.all_node_regions() |> Enum.sort() == ["ap-2", "us-east-1"]
+    end
+
+    test "with no other nodes, returns my region only" do
+      assert Nodes.all_node_regions() == ["us-east-1"]
+    end
+  end
+
   describe "region_nodes/1" do
     test "nil region returns empty list" do
       assert Nodes.region_nodes(nil) == []