Skip to content

Commit e6361d0

Browse files
ParisMeulemanChromium LUCI CQ
authored andcommitted
Rename DanglingAcrossTasks to AcrossTasksDanglingUntriaged
Following up on https://chromium-review.googlesource.com/c/chromium/src/+/4567353/comments/67bd2f0d_b10f9056 Add back DanglingUntriaged into the name of this trait. Keep the name consistent with other traits. Change-Id: I2702f843d9e81b87656ca31fd4c9ba19943d44d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4675808 Commit-Queue: Pâris Meuleman <[email protected]> Owners-Override: danakj <[email protected]> Reviewed-by: danakj <[email protected]> Cr-Commit-Position: refs/heads/main@{#1172247}
1 parent 06a874f commit e6361d0

File tree

626 files changed

+1306
-1053
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

626 files changed

+1306
-1053
lines changed

ash/frame_sink/frame_sink_holder_test_api.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class FrameSinkHolderTestApi {
3030
bool IsFirstFrameRequested() const;
3131

3232
private:
33-
raw_ptr<FrameSinkHolder, DanglingAcrossTasks> frame_sink_holder_;
33+
raw_ptr<FrameSinkHolder, AcrossTasksDanglingUntriaged> frame_sink_holder_;
3434
};
3535

3636
} // namespace ash

ash/frame_sink/test/test_begin_frame_source.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class TestBeginFrameSource : public viz::BeginFrameSource {
4646
viz::BeginFrameObserver* GetBeginFrameObserver() const;
4747

4848
private:
49-
raw_ptr<viz::BeginFrameObserver, DanglingAcrossTasks> observer_;
49+
raw_ptr<viz::BeginFrameObserver, AcrossTasksDanglingUntriaged> observer_;
5050
};
5151

5252
viz::BeginFrameArgs CreateValidBeginFrameArgsForTesting();

ash/in_session_auth/authentication_dialog.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class AuthenticationDialog : public views::DialogDelegateView {
4141
}
4242

4343
private:
44-
raw_ptr<AuthenticationDialog, DanglingAcrossTasks> const dialog_;
44+
raw_ptr<AuthenticationDialog, AcrossTasksDanglingUntriaged> const dialog_;
4545
};
4646

4747
// |on_auth_complete| is called when the user has been authenticated

ash/in_session_auth/authentication_dialog_unittest.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,9 @@ class AuthenticationDialogTest : public AshTestBase {
117117

118118
absl::optional<bool> success_;
119119
base::UnguessableToken token_;
120-
raw_ptr<AuthenticationDialog, DanglingAcrossTasks> dialog_;
120+
raw_ptr<AuthenticationDialog, AcrossTasksDanglingUntriaged> dialog_;
121121
std::unique_ptr<MockInSessionAuthTokenProvider> auth_token_provider_;
122-
raw_ptr<MockAuthPerformer, DanglingAcrossTasks> auth_performer_;
122+
raw_ptr<MockAuthPerformer, AcrossTasksDanglingUntriaged> auth_performer_;
123123
std::unique_ptr<AuthenticationDialog::TestApi> test_api_;
124124
};
125125

ash/login/ui/lock_contents_view.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -445,8 +445,8 @@ class ASH_EXPORT LockContentsView
445445

446446
// If the kiosk app button is not visible, the kiosk app default message would
447447
// be shown.
448-
raw_ptr<KioskAppDefaultMessage, DanglingAcrossTasks> kiosk_default_message_ =
449-
nullptr;
448+
raw_ptr<KioskAppDefaultMessage, AcrossTasksDanglingUntriaged>
449+
kiosk_default_message_ = nullptr;
450450

451451
// Actions that should be executed before a new layout happens caused by a
452452
// display change (eg. screen rotation). A full layout pass is performed after
@@ -473,7 +473,7 @@ class ASH_EXPORT LockContentsView
473473
raw_ptr<LoginErrorBubble, ExperimentalAsh> warning_banner_bubble_;
474474

475475
// View that is shown on login timeout with camera usage.
476-
raw_ptr<LoginCameraTimeoutView, DanglingAcrossTasks>
476+
raw_ptr<LoginCameraTimeoutView, AcrossTasksDanglingUntriaged>
477477
login_camera_timeout_view_ = nullptr;
478478

479479
// Bottom status indicator displaying entreprise domain or ADB enabled alert

base/allocator/partition_allocator/pointers/raw_ptr.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -948,7 +948,7 @@ constexpr auto FlakyDanglingUntriaged = base::RawPtrTraits::kMayDangle;
948948
// one task, and the raw_ptr was released in a different one.
949949
//
950950
// This is not meant to be added manually. You can ignore this flag.
951-
constexpr auto DanglingAcrossTasks = base::RawPtrTraits::kMayDangle;
951+
constexpr auto AcrossTasksDanglingUntriaged = base::RawPtrTraits::kMayDangle;
952952

953953
// The use of pointer arithmetic with raw_ptr is strongly discouraged and
954954
// disabled by default. Usually a container like span<> should be used

base/files/file_descriptor_watcher_posix.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ class FileDescriptorWatcher::Controller::Watcher
6767

6868
// WaitableEvent to signal to ensure that the Watcher is always destroyed
6969
// before the Controller.
70-
const raw_ref<base::WaitableEvent, DanglingAcrossTasks> on_destroyed_;
70+
const raw_ref<base::WaitableEvent, AcrossTasksDanglingUntriaged>
71+
on_destroyed_;
7172

7273
// Whether this Watcher is notified when |fd_| becomes readable or writable
7374
// without blocking.

base/files/file_descriptor_watcher_posix.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class BASE_EXPORT FileDescriptorWatcher {
7676
// Controller is deleted, ownership of |watcher_| is transfered to a delete
7777
// task posted to the MessageLoopForIO. This ensures that |watcher_| isn't
7878
// deleted while it is being used by the MessageLoopForIO.
79-
raw_ptr<Watcher, DanglingAcrossTasks> watcher_;
79+
raw_ptr<Watcher, AcrossTasksDanglingUntriaged> watcher_;
8080

8181
// An event for the watcher to notify controller that it's destroyed.
8282
// As the |watcher_| is owned by Controller, always outlives the Watcher.

base/message_loop/message_pump_libevent.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ class BASE_EXPORT MessagePumpLibevent : public MessagePump,
9393
friend class RefCounted<EpollInterest>;
9494
~EpollInterest();
9595

96-
const raw_ptr<FdWatchController, DanglingAcrossTasks> controller_;
96+
const raw_ptr<FdWatchController, AcrossTasksDanglingUntriaged> controller_;
9797
const EpollInterestParams params_;
9898
bool active_ = true;
9999
bool was_controller_destroyed_ = false;

base/observer_list_internal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class BASE_EXPORT UncheckedObserverAdapter {
5454
#endif // DCHECK_IS_ON()
5555

5656
private:
57-
raw_ptr<void, DanglingAcrossTasks> ptr_;
57+
raw_ptr<void, AcrossTasksDanglingUntriaged> ptr_;
5858
#if DCHECK_IS_ON()
5959
base::debug::StackTrace stack_;
6060
#endif // DCHECK_IS_ON()

0 commit comments

Comments
 (0)