Skip to content

Commit 34bfc57

Browse files
msisovChromium LUCI CQ
authored andcommitted
Clarify PRESUBMIT message for Lacros deprecation
The Lacros platform is deprecated, and its associated code is being removed. Previously, the PRESUBMIT script was updated to recommend transitioning to the IS_CHROMEOS build flag However, this change introduced ambiguity, leading to the misinterpretation that IS_CHROMEOS_LACROS should be renamed to IS_CHROMEOS alongside the IS_CHROMEOS_ASH build flag. This CL refines the PRESUBMIT message to clearly state: 1) Code under IS_CHROMEOS_LACROS must be removed. 2) The IS_CHROMEOS_ASH build flag should be renamed to IS_CHROMEOS. This update aims to eliminate confusion and provide precise guidance during the deprecation process. Bug: 388039763 Change-Id: I0cdd7a788da220ecca17f021a1597d2c41b2c05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6169131 Reviewed-by: Hidehiko Abe <[email protected]> Reviewed-by: Rick Byers <[email protected]> Commit-Queue: Maksim Sisov <[email protected]> Reviewed-by: Georg Neis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1405919}
1 parent f719372 commit 34bfc57

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

PRESUBMIT.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2122,7 +2122,8 @@ class BanRule:
21222122
r'IS_CHROMEOS_LACROS'),
21232123
explanation=
21242124
('Lacros is deprecated. Please do not use IS_CHROMEOS_ASH and '
2125-
'IS_CHROMEOS_LACROS anymore. Prefer IS_CHROMEOS instead.',
2125+
'IS_CHROMEOS_LACROS anymore. Instead, remove the code section under '
2126+
'IS_CHROMEOS_LACROS and use IS_CHROMEOS for ChromeOS-only code.',
21262127
),
21272128
treat_as_error=False,
21282129
),

0 commit comments

Comments
 (0)