Skip to content

Commit 5582a41

Browse files
authored
Few fixes around make for modules (redis#13922)
- Suppress errors when removing .so files that may not exist - Fix -DINCLUDE_VEC_SETS duplication
1 parent fd4b5cb commit 5582a41

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

modules/common.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ $(SRC_DIR)/.prepared:
3636

3737
clean:
3838
-$(MAKE) -C $(SRC_DIR) clean
39-
rm ./*.so
39+
-rm -f ./*.so
4040

4141
distclean: clean
4242
-$(MAKE) -C $(SRC_DIR) distclean

src/Makefile

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,12 @@ ifeq ($(BUILD_TLS),module)
317317
TLS_MODULE_CFLAGS+=-DUSE_OPENSSL=$(BUILD_MODULE) $(OPENSSL_CFLAGS) -DBUILD_TLS_MODULE=$(BUILD_MODULE)
318318
endif
319319

320+
ifneq ($(SKIP_VEC_SETS),yes)
321+
vpath %.c ../modules/vector-sets
322+
REDIS_VEC_SETS_OBJ=hnsw.o cJSON.o vset.o
323+
FINAL_CFLAGS+=-DINCLUDE_VEC_SETS=1
324+
endif
325+
320326
ifndef V
321327
define MAKE_INSTALL
322328
@printf ' %b %b\n' $(LINKCOLOR)INSTALL$(ENDCOLOR) $(BINCOLOR)$(1)$(ENDCOLOR) 1>&2
@@ -354,13 +360,6 @@ else
354360
GEN_COMMANDS_FLAGS=
355361
endif
356362

357-
358-
ifneq ($(SKIP_VEC_SETS),yes)
359-
vpath %.c ../modules/vector-sets
360-
REDIS_VEC_SETS_OBJ=hnsw.o cJSON.o vset.o
361-
CFLAGS+=-DINCLUDE_VEC_SETS=1
362-
endif
363-
364363
REDIS_SERVER_NAME=redis-server$(PROG_SUFFIX)
365364
REDIS_SENTINEL_NAME=redis-sentinel$(PROG_SUFFIX)
366365
REDIS_SERVER_OBJ=threads_mngr.o adlist.o quicklist.o ae.o anet.o dict.o ebuckets.o eventnotifier.o iothread.o mstr.o kvstore.o server.o sds.o zmalloc.o lzf_c.o lzf_d.o pqsort.o zipmap.o sha1.o ziplist.o release.o networking.o util.o object.o db.o replication.o rdb.o t_string.o t_list.o t_set.o t_zset.o t_hash.o config.o aof.o pubsub.o multi.o debug.o sort.o intset.o syncio.o cluster.o cluster_legacy.o crc16.o endianconv.o slowlog.o eval.o bio.o rio.o rand.o memtest.o syscheck.o crcspeed.o crccombine.o crc64.o bitops.o sentinel.o notify.o setproctitle.o blocked.o hyperloglog.o latency.o sparkline.o redis-check-rdb.o redis-check-aof.o geo.o lazyfree.o module.o evict.o expire.o geohash.o geohash_helper.o childinfo.o defrag.o siphash.o rax.o t_stream.o listpack.o localtime.o lolwut.o lolwut5.o lolwut6.o acl.o tracking.o socket.o tls.o sha256.o timeout.o setcpuaffinity.o monotonic.o mt19937-64.o resp_parser.o call_reply.o script_lua.o script.o functions.o function_lua.o commands.o strl.o connection.o unix.o logreqres.o

0 commit comments

Comments
 (0)