replacing 3.3.3 (x64) with 3.5.2 (x64) fails on WindowsServer2019 , installer just says "failed" on last screen

[LifesTough4321]

replacing 3.3.3 (x64) with 3.5.2 (x64) fails on WindowsServer2019, installer just says "failed" on last screen
problem is sumatrapdf 3.3.3 is on many servers, and I dont want to remove it in case 3.5.2 isnt installable even after removeing 3.3.3
what to check for?

[kjk]

Check / post the log file: https://www.sumatrapdfreader.org/docs/Installer-cmd-line-arguments (-log cmd-line arg to specify path of log file, defaults to %LOCALAPPDATA%\sumatra-install-log.txt)

Try pre-release - the are fixes to installer there and more detailed logging to figure out what went wrong.

[LifesTough4321]

------------- Starting SumatraPDF installation
OpenEmbeddedFilesArchive: opened archive
GetExistingInstallationDir()
ReadRegStrTemp(HKEY_LOCAL_MACHINE, Software\Microsoft\Windows\CurrentVersion\Uninstall\SumatraPDF, InstallLocation) => 'C:\Program Files\SumatraPDF'
ReadRegStrTemp(HKEY_CLASSES_ROOT, .pdf\PersistentHandler, (null)) => '(null)'
IsSearchFilterInstalled() isInstalled=0
ReadRegStrTemp(HKEY_CLASSES_ROOT, .pdf\shellex{8895b1c6-b41f-4c1c-a562-0d564250836f}, (null)) => '(null)'
IsPreviewInstalled() isInstalled=0
ReadRegStrTemp(HKEY_LOCAL_MACHINE, Software\Microsoft\Windows\CurrentVersion\Uninstall\SumatraPDF, InstallLocation) => 'C:\Program Files\SumatraPDF'
ReadRegStrTemp(HKEY_CURRENT_USER, Software\Microsoft\Windows\CurrentVersion\Uninstall\SumatraPDF, InstallLocation) => '(null)'
GetPreviousInstallInfo: dir 'C:\Program Files\SumatraPDF', search filter: 0, preview: 0, typ: 2, needsElevation: 1
HasPreviousInstall(): hasPrev: 1
Running'C:_install\SumatraPDF-3.6.17562-x64-install.exe', cmdLine: '"C:_install\SumatraPDF-3.6.17562-x64-install.exe" -run-install-now -all-users -silent -log -install-dir "C:\Program Files\SumatraPDF"', installing into dir 'C:\Program Files\SumatraPDF'
RunInstaller: gCliNew.silent: 1, gCliNew.allUsers: 1, gCliNew.runInstallNow: 1, gCliNew.withFilter: 0, gCliNew.withPreview: 0, gCliNew.fastInstall: 0
InstallerThread: cli->allUsers: 1, cli->withFilter: 0, cli->withPreview: 0, installerExePath: 'C:\Program Files\SumatraPDF\SumatraPDF.exe'
ExtractInstallerFiles() to 'C:\Program Files\SumatraPDF'
CopySelfToDir(C:\Program Files\SumatraPDF)
LogLastError: 0x0 (0) 'Zugriff verweigert'
failed to copy 'C:_install\SumatraPDF-3.6.17562-x64-install.exe' to dir 'C:\Program Files\SumatraPDF'
ExtractInstallerFiles() failed
Installer finished
RunNonElevated: 'C:\Users\domadminad\AppData\Local\Temp\sumatra-install-log.txt'

SHA256-Hash von SumatraPDF-3.6.17562-x64-install.exe:
62e59deafd864563ab945969672b47e0c9c59925a10dcbf09e66f12ee79e28ef
CertUtil: -hashfile-Befehl wurde erfolgreich ausgeführt.

[kjk]

This is a failure to elevate installer to admin when installing for all users. Without that we can't write to Program Files => installation error.

It'll work if you run it as admin. I'll try to fix failure to elevate in next build.

But I want to understand: how did that happen. How exactly are you running the installer?

[LifesTough4321]

This is a runofthemill windows server 2019, domainjoined, on vmware, other installed software is 7zip, firefox and a database sOftware which name I cannot disclOse.
Installer is started from a cmd, started as admin, useraccount is domainadmin so localadmin by inheritance.
I just need to get rid of the 3.3.x versions because 3.5.x has been out a while and we do not want to be an easy target for a security audit,

[kjk]

Installer is started from a cmd

Started how? Did yourun SumatraPDF-3.6.17562-x64-install.exe without any cmd-line flags? If not, what flags did you use?

Did you run it manually or from a script?

started as admin, useraccount is domainadmin so localadmin by inheritance

Was the terminal/cmd elevated? i.e. did you run it with "Run As Administrator"

What I know for sure from logs is that installer failed because it couldn't write to C:\Program Files\SumatraPDF. That's almost certainly because the process wasn't running as elevated. Or file permissions issue.

If you didn't explicitly use "Run Ad Administrator" on installer or terminal/cmd from which you ran the installer, then I can't know it was actually running as admin.

I've added more logging about that to the installer so if it continues to not work, there'll be more info in logs.

[LifesTough4321]

im running it manually with -all-users -s
the terminal was elevated
but later i plan to deploy via a deployment system, which I cannot name buth it can deploy updates for winscp, firefox, 7zip silently so its capable for the existing workload.

[kjk]

Please try build 17570 - it should detect this scenario and ask to elevate to admin.

But I don't have a setup to test it so please let me know if it worked.

[LifesTough4321]

this will take at least a week, no joke, I can only do software maintenance on one day per week if at all.