Skip to content

Commit d159a19

Browse files
committed
fixup! ✨(frontend) improve accessibility of cdoc content with correct aria tags
1 parent 8ccde79 commit d159a19

File tree

3 files changed

+5
-25
lines changed

3 files changed

+5
-25
lines changed

src/frontend/apps/e2e/__tests__/app-impress/doc-create.spec.ts

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,8 @@ test.describe('Doc Create', () => {
4545
})
4646
.click();
4747

48-
await page.waitForURL('**/docs/**', {
49-
timeout: 10000,
50-
waitUntil: 'domcontentloaded',
51-
});
52-
5348
const input = page.getByRole('textbox', { name: 'Document title' });
54-
await expect(input).toHaveText('');
49+
await expect(input).toHaveText('', { timeout: 10000 });
5550
await expect(
5651
page.locator('.c__tree-view--row-content').getByText('Untitled document'),
5752
).toBeVisible();
@@ -72,13 +67,8 @@ test.describe('Doc Create', () => {
7267
.getByText('New sub-doc')
7368
.click();
7469

75-
await page.waitForURL('**/docs/**', {
76-
timeout: 10000,
77-
waitUntil: 'domcontentloaded',
78-
});
79-
8070
const input = page.getByRole('textbox', { name: 'Document title' });
81-
await expect(input).toHaveText('');
71+
await expect(input).toHaveText('', { timeout: 10000 });
8272
await expect(
8373
page.locator('.c__tree-view--row-content').getByText('Untitled document'),
8474
).toBeVisible();

src/frontend/apps/e2e/__tests__/app-impress/doc-export.spec.ts

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -396,13 +396,9 @@ test.describe('Doc Export', () => {
396396
})
397397
.click();
398398

399-
await page.waitForURL('**/docs/**', {
400-
timeout: 10000,
401-
waitUntil: 'domcontentloaded',
402-
});
403-
404399
const input = page.locator('.--docs--doc-title-input[role="textbox"]');
405-
await expect(input).toBeVisible({ timeout: 20000 });
400+
await expect(input).toBeVisible();
401+
await expect(input).toHaveText('', { timeout: 10000 });
406402
await input.click();
407403
await input.fill(randomDocFrench);
408404
await input.blur();
@@ -473,12 +469,6 @@ test.describe('Doc Export', () => {
473469

474470
await expect(interlink).toBeVisible();
475471

476-
// Open export modal before triggering the download
477-
await page.getByTestId('doc-open-modal-download-button').click();
478-
await expect(
479-
page.getByTestId('doc-open-modal-download-button'),
480-
).toBeVisible();
481-
482472
const downloadPromise = page.waitForEvent('download', (download) => {
483473
return download.suggestedFilename().includes(`${docChild}.pdf`);
484474
});

src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ test.describe('Doc Header', () => {
6666
browserName,
6767
}) => {
6868
await createDoc(page, 'doc-update', browserName, 1);
69-
const docTitle = page.getByRole('textbox', { name: 'doc title input' });
69+
const docTitle = page.getByRole('textbox', { name: 'Document title' });
7070
await expect(docTitle).toBeVisible();
7171
await docTitle.fill('👍 Hello Emoji World');
7272
await docTitle.blur();

0 commit comments

Comments
 (0)