From 2bc31464fb4624ce11381fd10bb38755d781ddc5 Mon Sep 17 00:00:00 2001 From: omsuneri <142336291+omsuneri@users.noreply.github.com> Date: Wed, 9 Oct 2024 04:21:57 +0530 Subject: [PATCH 1/2] FIXES ISSUE #4012 Scalar Step doesn't work for default temperaments (other than 12EDO) after these changes the scalar step (+/-) block stepping up and down pitch perfectly for the temperaments other than Equal 12EDO and Custom --- js/utils/musicutils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/utils/musicutils.js b/js/utils/musicutils.js index 3d2290d0e6..6ad076e669 100644 --- a/js/utils/musicutils.js +++ b/js/utils/musicutils.js @@ -3824,7 +3824,7 @@ function getNote( let note; let articulation; - if (temperament === "equal") { + if (temperament = "equal") { // Check for double flat or double sharp. Since bb and x behave // funny with string operations, we jump through some hoops. articulation = getArticulation(noteArg); From 2461594cba50b90b7477275be466a5423166081c Mon Sep 17 00:00:00 2001 From: omsuneri <142336291+omsuneri@users.noreply.github.com> Date: Wed, 9 Oct 2024 16:57:58 +0530 Subject: [PATCH 2/2] FIXES ISSUE sugarlabs#4012 Scalar Step doesn't work for default temperaments (other than 12EDO) --- js/utils/musicutils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/utils/musicutils.js b/js/utils/musicutils.js index 6ad076e669..c51a0b44f3 100644 --- a/js/utils/musicutils.js +++ b/js/utils/musicutils.js @@ -3824,7 +3824,7 @@ function getNote( let note; let articulation; - if (temperament = "equal") { + if (temperament in PreDefinedTemperaments) { // Check for double flat or double sharp. Since bb and x behave // funny with string operations, we jump through some hoops. articulation = getArticulation(noteArg);