Bug: Duplicate method in SensorsBlocks implementation

[Adityacode-hub]

Description

There is a duplicate method in the SensorsBlocks implementation which causes redundant behavior.

Solution

Removed duplicate method and updated the related test cases.

PR Reference

This issue replaces PR #4790 which was closed for missing issue reference.

Additional Info

All Jest tests passed locally.

[sanuxdev]

Hi @zealot-zew 👋
I went through the SensorsBlocks implementation and understood the issue. It seems that there’s a duplicate method defined, which is causing redundant or repeated behavior in the codebase. From what I can see, both methods are serving the same purpose, and the duplicate one is unnecessary.

My plan is to remove the redundant method and ensure that all related references and Jest test cases are updated accordingly so that the functionality remains consistent. I’ll also verify that all tests pass locally before raising the PR.

If possible, could you please assign this issue to me? I’d like to work on fixing it. 😊

Thanks!
— Sanu Kumar

[Priyanshubhartistm]

assign this issue please

[Adityacode-hub]

What is the issue with my code will you please describe

[Samriddhi-20619]

Hi, i'd like to work on this issue . can you please assign me ?

[prachi-kCoder]

Hi @zealot-zew and MusicBlocks team,

While reviewing SensorBlocks.js for Issue #4793, I noticed that although some functions have similar names, there isn’t an actual duplicate method definition. The confusion likely stems from naming conventions and overlapping logic, which I initially mistook for redundancy.

However, during my exploration, I identified a separate potential bug in the GetBlueBlock class (extending ValueBlock).

replace: return parseInt(Number(obj[0]) / 2.55);
with : return parseInt(Number(obj[2]) / 2.55); ie Blue content retrieval

I’ve already cloned and set up the project locally, and I’m comfortable working with the codebase and Jest tests. Could you please guide me on whether i am right or not ? and whether this should be filed as a new issue or if I can proceed with a PR directly?

Looking forward to contributing meaningfully to MusicBlocks and Sugar Labs.

[Richadas123]

Hi @zealot-zew and MusicBlocks team,

I would like to work on this issue.

I have experience with JavaScript, React, and debugging UI logic, and I am comfortable refactoring code and working with Jest tests. I have handled similar debugging in my MERN projects, so I can fix the duplicate method in SensorsBlocks and update the test cases accordingly.

Could you please assign this issue to me?

Thanks!