Skip to content

Commit b46ef2c

Browse files
committed
fixes #624 -- consider beat factor when calcualting note count
1 parent cb12d2c commit b46ef2c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

js/logo.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4494,7 +4494,7 @@ function Logo(pitchtimematrix, pitchdrummatrix, rhythmruler,
44944494
}
44954495

44964496
// How best to expose this in the UI? What units?
4497-
this.notesPlayed[turtle] += (1 / noteValue);
4497+
this.notesPlayed[turtle] += (1 / (noteValue * this.beatFactor[turtle]));
44984498

44994499
var vibratoRate = 0;
45004500
var vibratoValue = 0;
@@ -4758,8 +4758,9 @@ function Logo(pitchtimematrix, pitchdrummatrix, rhythmruler,
47584758
var beatValue = bpmFactor / (noteBeatValue * logo.noteBeatValues[turtle][0]);
47594759
}
47604760

4761-
if (doVibrato)
4761+
if (doVibrato) {
47624762
vibratoValue = beatValue * (duration / vibratoRate);
4763+
}
47634764

47644765
logo._dispatchTurtleSignals(turtle, beatValue, blk, noteBeatValue);
47654766
// Process pitches

0 commit comments

Comments
 (0)