ask for permission to open midi device -- see #2661

walterbender · walterbender · commit 48c502d4d4d9 · 2020-12-22T18:26:47.000-05:00
diff --git a/js/widgets/musickeyboard.js b/js/widgets/musickeyboard.js
@@ -2941,8 +2941,11 @@ function MusicKeyboard() {
             this.midiON = false;
         }
 
-        navigator.requestMIDIAccess()
-            .then(onMIDISuccess, onMIDIFailure);
+        if (navigator.requestMIDIAccess)
+            navigator.requestMIDIAccess({ sysex: true })
+                .then(onMIDISuccess, onMIDIFailure);
+        else
+            logo.errorMsg(_("Failed to get MIDI access in browser."));
     }
 
     function fillChromaticGaps(noteList) {

Original file line number	Diff line number	Diff line change
`@@ -2941,8 +2941,11 @@ function MusicKeyboard() {`
`2941`	`2941`	`this.midiON = false;`
`2942`	`2942`	`}`
`2943`	`2943`
`2944`		`- navigator.requestMIDIAccess()`
`2945`		`- .then(onMIDISuccess, onMIDIFailure);`
	`2944`	`+ if (navigator.requestMIDIAccess)`
	`2945`	`+ navigator.requestMIDIAccess({ sysex: true })`
	`2946`	`+ .then(onMIDISuccess, onMIDIFailure);`
	`2947`	`+ else`
	`2948`	`+ logo.errorMsg(_("Failed to get MIDI access in browser."));`
`2946`	`2949`	`}`
`2947`	`2950`
`2948`	`2951`	`function fillChromaticGaps(noteList) {`