Fix 'Ti' pitch capitalization issue causing undefined behavior

- Fix pie menu selection logic to handle case-insensitive pitch lookups
- Fix i18nSolfege function to normalize input/output to lowercase
- Fix pie menu label processing to ensure consistent case handling
- Resolves issue where 'Ti' pitch showed as 'undefined' when collapsed
- Fixes Japanese localization issue (TiNaN -> ti)
- Addresses GitHub issue #4779

Author: Aayushdev18

js/block.js

@@ -3433,9 +3433,11 @@ class Block {
             // solfnotes_ is used in the interface for internationalization.
             //.TRANS: the note names must be separated by single spaces
             const solfnotes_ = _("ti la sol fa mi re do").split(" ");
+            // Ensure all solfege notes are lowercase for consistent processing
+            const normalizedSolfnotes_ = solfnotes_.map(note => note.toLowerCase());
 
             if (this.piemenuOKtoLaunch()) {
-                piemenuPitches(this, solfnotes_, SOLFNOTES, SOLFATTRS, obj[0], obj[1]);
+                piemenuPitches(this, normalizedSolfnotes_, SOLFNOTES, SOLFATTRS, obj[0], obj[1]);
             }
         } else if (this.name === "scaledegree2") {
             obj = splitScaleDegree(this.value);

js/piemenus.js

@@ -399,7 +399,9 @@ const piemenuPitches = (
             }
 
             const label = that._pitchWheel.navItems[that._pitchWheel.selectedNavItemIndex].title;
-            const i = noteLabels.indexOf(label);
+            // Ensure consistent case for lookup - convert to lowercase for comparison
+            const normalizedLabel = label.toLowerCase();
+            const i = noteLabels.indexOf(normalizedLabel);
 
             // Are we wrapping across C? We need to compare with the previous pitch
             if (prevPitch === null) {
@@ -541,7 +543,9 @@ const piemenuPitches = (
 
     const __selectionChangedSolfege = () => {
         selection["note"] = that._pitchWheel.navItems[that._pitchWheel.selectedNavItemIndex].title;
-        const i = noteLabels.indexOf(selection["note"]);
+        // Ensure consistent case for lookup - convert to lowercase for comparison
+        const normalizedNote = selection["note"].toLowerCase();
+        const i = noteLabels.indexOf(normalizedNote);
         that.value = noteValues[i];
 
         // Auto-selection of sharps and flats in fixed solfege handles
@@ -558,21 +562,23 @@ const piemenuPitches = (
                     )
                     : true))
         ) {
-            let i = scale.indexOf(selection["note"]);
+            // Use normalized note for scale lookup
+            const normalizedSelectionNote = selection["note"].toLowerCase();
+            let i = scale.indexOf(normalizedSelectionNote);
             if (i === -1) {
                 i = scale.indexOf(that.value);
             }
             if (i === -1) {
-                i = NOTENAMES.indexOf(FIXEDSOLFEGE[selection["note"]]);
+                i = NOTENAMES.indexOf(FIXEDSOLFEGE[normalizedSelectionNote]);
             }
             if (i === -1) {
                 i = NOTENAMES.indexOf(FIXEDSOLFEGE[that.value]);
             }
             if (
                 NOTENAMES.includes(selection["note"]) ||
-                scale[i][0] === FIXEDSOLFEGE[selection["note"]] ||
+                scale[i][0] === FIXEDSOLFEGE[normalizedSelectionNote] ||
                 scale[i][0] === FIXEDSOLFEGE[that.value] ||
-                scale[i][0] === selection["note"]
+                scale[i][0] === normalizedSelectionNote
             ) {
                 selection["attr"] = scale[i].substr(1);
             } else {

js/utils/musicutils.js

@@ -5787,9 +5787,12 @@ const i18nSolfege = (note) => {
     const solfnotes_ = _("ti la sol fa mi re do").split(" ");
     const obj = splitSolfege(note);
 
-    const i = SOLFNOTES.indexOf(obj[0]);
+    // Normalize the note part to lowercase for lookup
+    const normalizedNote = obj[0].toLowerCase();
+    const i = SOLFNOTES.indexOf(normalizedNote);
     if (i !== -1) {
-        return solfnotes_[i] + obj[1];
+        // Ensure the internationalized solfege note is always lowercase
+        return solfnotes_[i].toLowerCase() + obj[1];
     } else {
         // Wasn't solfege so it doesn't need translation.
         return note;