fix: sbtc testnet #2562
fix: sbtc testnet #2562
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nick-stacks
force-pushed
the
fix/sbtc-balance-testnet
branch
from
9e97b0a to
a2bdc58
Compare
nick-stacks
force-pushed
the
fix/sbtc-balance-testnet
branch
from
a2bdc58 to
82214d7
Compare
| export const getHasSBTCInName = (name: string, symbol: string) => { | ||
| if (!name || !symbol) { | ||
| return false; | ||
| } | ||
| return name.toLowerCase().includes('sbtc') || symbol.toLowerCase().includes('sbtc'); | ||
| }; |
There was a problem hiding this comment.
guard condition here returns false if either values are falsy, but the return statement checks if either contains 'sbtc', is this intended?
There was a problem hiding this comment.
Yes. This seems logical to me. Do you think it should work differently?
There was a problem hiding this comment.
this condition name.toLowerCase().includes('sbtc') || symbol.toLowerCase().includes('sbtc') says it should return true if either name or symbol contains sbtc, but the guard condition wants them both to exist, if you truly want to return true if any of name/symbol contains sbtc you should probably switch the guard condition to !name && !symbol, unless you want both to have sbtc then you can change the 2nd condition to &&
There was a problem hiding this comment.
do you want getHasSBTCInName ('sbtc', 'notsbtc') to return true and getHasSBTCInName ('sbtc', undefined) to return false?
nick-stacks
force-pushed
the
fix/sbtc-balance-testnet
branch
from
82214d7 to
6784e25
Compare
What type of PR is this? (check all applicable)
Description
Fixes sbtc issues on testnet
sbtc navbar link went to the mainnet sbtc page
sbtc testnet balances were 0
sbtc token page showed the token as unverified
Issue ticket number and link
Checklist:
Screenshots (if appropriate):