fix: unit tests

Author: gajddo00

Sources/Networking/Core/Upload/UploadAPIManager.swift

@@ -150,8 +150,8 @@ extension UploadAPIManager: URLSessionTaskDelegate {
 
 // MARK: - UploadAPIManaging
 @available(iOS 15.0, *)
-extension UploadAPIManager {
-    public func upload(_ type: UploadType, to endpoint: Requestable) async throws -> UploadTask {
+public extension UploadAPIManager {
+    func upload(_ type: UploadType, to endpoint: Requestable) async throws -> UploadTask {
         let endpointRequest = EndpointRequest(endpoint, sessionId: sessionId)
 
         switch type {
@@ -188,15 +188,15 @@ extension UploadAPIManager {
         }
     }
 
-    public func invalidateSession(shouldFinishTasks: Bool) {
+    func invalidateSession(shouldFinishTasks: Bool) {
         if shouldFinishTasks {
             urlSession.finishTasksAndInvalidate()
         } else {
             urlSession.invalidateAndCancel()
         }
     }
 
-    public func retry(taskId: String) async throws {
+    func retry(taskId: String) async throws {
         // Get stored upload task to invoke the request with the same arguments
         guard let existingUploadTask = uploadTasks[taskId] else {
             throw NetworkError.unknown
@@ -212,7 +212,7 @@ extension UploadAPIManager {
         )
     }
 
-    public func stateStream(for uploadTaskId: UploadTask.ID) -> StateStream {
+    func stateStream(for uploadTaskId: UploadTask.ID) -> StateStream {
         let uploadTask = uploadTasks.values.first { $0.id == uploadTaskId }
 
         return uploadTask?.stateStream ?? AsyncStream.makeStream(of: UploadTask.State.self).stream

Sources/Networking/Modifiers/Processors/EndpointRequestStorageProcessor/EndpointRequestStorageProcessor.swift

@@ -60,16 +60,15 @@ open class EndpointRequestStorageProcessor: ResponseProcessing, ErrorProcessing
         config: .init(
             multiPeerSharing: .init(shareHistory: true),
             storedSessionsLimit: 5
-        ),
-        deviceName: UUID().uuidString
+        )
     )
 
     public init(
         fileManager: FileManager = .default,
         fileDataWriter: FileDataWriting = FileDataWriter(),
         jsonEncoder: JSONEncoder? = nil,
         config: Config = .default,
-        deviceName: String
+        deviceName: String = UUID().uuidString
     ) {
         self.fileManager = fileManager
         self.fileDataWriter = fileDataWriter

Tests/NetworkingTests/EndpointRequestStorageProcessorTests.swift

@@ -88,7 +88,8 @@ final class EndpointRequestStorageProcessorTests: XCTestCase {
         let mockURLResponse: URLResponse = HTTPURLResponse(url: MockRouter.testStoringGet.baseURL, statusCode: 200, httpVersion: nil, headerFields: nil)!
         let mockResponse = (Data(), mockURLResponse)
 
-        let response = try await EndpointRequestStorageProcessor().process(mockResponse, with: mockURLRequest, for: mockEndpointRequest)
+        let response = try await EndpointRequestStorageProcessor()
+            .process(mockResponse, with: mockURLRequest, for: mockEndpointRequest)
 
         // test storing data processor doesn't effect response in anyway
         XCTAssertEqual(response.data, mockResponse.0)
@@ -134,7 +135,7 @@ final class EndpointRequestStorageProcessorTests: XCTestCase {
             httpVersion: nil,
             headerFields: ["mockResponseHeader": "mock"]
         )!
-        let mockResponseData = "Mock data".data(using: .utf8)!
+        let mockResponseData = Data("Mock data".utf8)
         let mockResponse = (mockResponseData, mockURLResponse)
         let expectation = expectation(description: "Data was written")
 
@@ -236,7 +237,7 @@ final class EndpointRequestStorageProcessorTests: XCTestCase {
             httpVersion: nil,
             headerFields: ["mockResponseHeader": "mock"]
         )!
-        let mockResponseData = "Not found".data(using: .utf8)!
+        let mockResponseData = Data("Not found".utf8)
         let mockResponse = (mockResponseData, mockURLResponse)
         let mockError = NetworkError.unacceptableStatusCode(
             statusCode: 404,
@@ -291,7 +292,7 @@ final class EndpointRequestStorageProcessorTests: XCTestCase {
             httpVersion: nil,
             headerFields: ["mockResponseHeader": "mock"]
         )!
-        let mockResponseData = "Mock data".data(using: .utf8)!
+        let mockResponseData = Data("Mock data".utf8)
         let mockResponse = (mockResponseData, mockURLResponse)
 
         let expectation = expectation(description: "Data was written")

Tests/NetworkingTests/Mocks/MockFileManager.swift

@@ -9,7 +9,7 @@ import Foundation
 import XCTest
 
 /// A subclass of `FileManager` where the file existence is based on a dictionary whose key is the file path.
-final class MockFileManager: FileManager {
+final class MockFileManager: FileManager, @unchecked Sendable {
     enum Function: Equatable {
         case fileExists(path: String)
         case createDirectory(path: String)

Tests/NetworkingTests/URLParametersTests.swift

@@ -12,7 +12,7 @@ private let baseURLString = "https://requestable.tests"
 
 final class URLParametersTests: XCTestCase {
     enum Router: Requestable {
-        case urlParameters([String: Any])
+        case urlParameters([String: any Sendable])
 
         var baseURL: URL {
             // swiftlint:disable:next force_unwrapping

Tests/NetworkingTests/UploadAPIManagerTests.swift

@@ -9,6 +9,7 @@
 import XCTest
 
 @NetworkingActor
+@available(iOS 15.0, *)
 final class UploadAPIManagerTests: XCTestCase {
     enum UploadRouter: Requestable {
         case mock
@@ -41,7 +42,10 @@ final class UploadAPIManagerTests: XCTestCase {
                 try await withThrowingTaskGroup(of: Void.self) { group in
                     for _ in 0..<15 {
                         group.addTask {
-                            _ = try await apiManager.upload(data: data, to: UploadRouter.mock)
+                            _ = try await apiManager.upload(
+                                .data(data, contentType: "text"),
+                                to: UploadRouter.mock
+                            )
                         }
                     }