common/types: handle fallback case for malformed operations entries #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt1360
commented
Nov 4, 2025
| func (ops *Operations) AssociatedTask() (string, error) { | ||
| // The operations type lacks a client to fetch a task from this link | ||
| // and further, Task is a type in the redfish package. | ||
| // return GetObjects[Task](ops.GetClient(), ops.associatedTask) |
Contributor
Author
There was a problem hiding this comment.
I'm not sure what the right approach here should be, since it's in the common package. I didn't want to introduce an intrusive change with a larger blast radius. Let me know how you'd like this to be handled, and I can massage it into place.
Owner
There was a problem hiding this comment.
Can't look too closely at the moment, but will try to get to it very soon.
We may want/need to move the Task definition to common too so we can just return the task. If Operation is used by both redfish and swordfish, then it would make sense to make it a common object. We could have a redfish.Task that just wraps the common.Task so we don't break anyone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, with some eject/insert/blink/unblink, I'm unable to get a pulse on what the BMC will actually present in the
AssociatedTask[]. I've taken a guess that it might be a[]Link.I've tested this with our nodes, on both the seemingly compliant (missing
Operations) older version, and newer version of the BMC.Fixes #469