Don't make use of the servicemanager in contrroller but inject

dependencies

Author: stijnhau

Module.php

@@ -34,4 +34,13 @@ public function getServiceConfig()
     {
         return include __DIR__ . '/config/services.config.php';
     }
+
+    public function getControllerConfig()
+    {
+        return array(
+            'factories' => array(
+                'zfcuserlist' => 'ZfcUserList\Controller\Factory\UserListController',
+            ),
+        );
+    }
 }

config/module.config.php

@@ -5,11 +5,6 @@
             'zfcuserlist' => __DIR__ . '/../view',
         ),
     ),
-    'controllers' => array(
-        'invokables' => array(
-            'zfcuserlist' => 'ZfcUserList\Controller\UserListController',
-        ),
-    ),
     'router' => array(
         'routes' => array(
             'zfcuser' => [

src/ZfcUserList/Controller/Factory/UserListController.php

@@ -0,0 +1,20 @@
+<?php
+namespace ZfcUserList\Controller\Factory;
+
+use Zend\ServiceManager\FactoryInterface;
+use Zend\ServiceManager\ServiceLocatorInterface;
+use ZfcUserList\Controller\UserListController;
+
+class UserListController implements FactoryInterface
+{
+    public function createService(ServiceLocatorInterface $sm)
+    {
+        $parentLocator = $sm->getServiceLocator();
+
+        $controller = new UserListController(
+            $parentLocator->get("zfcuserlist_module_options"),
+            $parentLocator->get("zfcuser_user_mapper")
+        );
+        return $controller;
+    }
+}

src/ZfcUserList/Controller/UserListController.php

@@ -10,23 +10,29 @@
 
 class UserListController extends AbstractActionController
 {
-    protected $options, $userMapper;
-    protected $zfcUserOptions;
+    protected $options;
+    protected $userMapper;
+
+    public function __construct(ModuleOptions $options, UserInterface $userMapper)
+    {
+        $this->setOptions($options);
+        $this->setUserMapper($userMapper);
+    }
+
     public function listAction()
     {
-        $userMapper = $this->getUserMapper();
-        $users = $userMapper->findAll();
+        $users = $this->userMapper->findAll();
         if (is_array($users)) {
             $paginator = new Paginator\Paginator(new Paginator\Adapter\ArrayAdapter($users));
         } else {
             $paginator = $users;
         }
 
-        $paginator->setItemCountPerPage($this->getOptions()->getElementsPerPage());
+        $paginator->setItemCountPerPage($this->options->getElementsPerPage());
         $paginator->setCurrentPageNumber($this->getEvent()->getRouteMatch()->getParam('p'));
         return array(
             'users' => $paginator,
-            'userlistElements' => $this->getOptions()->getUserListElements()
+            'userlistElements' => $this->options->getUserListElements()
         );
     }
 
@@ -36,41 +42,9 @@ public function setOptions(ModuleOptions $options)
         return $this;
     }
 
-    public function getOptions()
-    {
-        if (!$this->options instanceof ModuleOptions) {
-            $this->setOptions($this->getServiceLocator()->get('zfcuserlist_module_options'));
-        }
-        return $this->options;
-    }
-
-    public function getUserMapper()
-    {
-        if (null === $this->userMapper) {
-            $this->userMapper = $this->getServiceLocator()->get('zfcuser_user_mapper');
-        }
-        return $this->userMapper;
-    }
-
     public function setUserMapper(UserInterface $userMapper)
     {
         $this->userMapper = $userMapper;
         return $this;
     }
-    public function setZfcUserOptions(ZfcUserModuleOptions $options)
-    {
-        $this->zfcUserOptions = $options;
-        return $this;
-    }
-
-    /**
-     * @return \ZfcUser\Options\ModuleOptions
-     */
-    public function getZfcUserOptions()
-    {
-        if (!$this->zfcUserOptions instanceof ZfcUserModuleOptions) {
-            $this->setZfcUserOptions($this->getServiceLocator()->get('zfcuser_module_options'));
-        }
-        return $this->zfcUserOptions;
-    }
 }