fix: isValid() added to Transfer object. Plus tests to imitate incorrect Alchemy response #7181
+218
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect Alchemy response
vkjr
requested review from
Khushboo-dev-cpp,
alaibe,
dlipicar,
friofry and
saledjenic
Member
Jenkins Builds
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7181 +/- ##
===========================================
- Coverage 59.98% 59.97% -0.02%
===========================================
Files 809 809
Lines 113225 113252 +27
===========================================
+ Hits 67919 67922 +3
- Misses 38474 38504 +30
+ Partials 6832 6826 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherrypicking #7173 from release branch.
Incorrect Alchemy response could have lead to a crashes on app login.
So Transfer object got isValid() method to check this.
Tests were added to check these cases.