Fix stan_csv_reader and test

[betanalpha]

The stan_csv_reader is broken and has been for some time. The internal state is extremely fragile and right now it incorrectly parses the input data file. Any fix would require some significant hacking -- we really should fix this as a consequence of the refactor in #405 and #488, after which we'll have an actual spec for the reader to match.

Unit tests never revealed this to be an issue because the associated test, stan_csv_reader_test, uses static output files for comparison that were deprecated. We now have the makefile-fu to automatically generate these files and avoid this issue in the future.

[bob-carpenter]

Michael --- could you start a branch and add a test that fails? Or just include a file that fails here?

I'm pushing this off to 2.4.0+ for now, since it doesn't seem to be critical. If it is, can someone push it back down to 2.4.0 and commit to fixing it?

[bob-carpenter]

Michael --- if you want this fixed, could you be more specific about what's going wrong?

I'm pushing this issue off indefinitely pending some indication of what's broken.

[betanalpha]

The problem is that the csv_reader is hardcoded to an older set of configuration
options. It needs to automatically sync up with the current config (say, by actually
using the config code), but that requires a decision on how the config should be
used in the API.

On Sep 22, 2014, at 11:29 PM, Bob Carpenter notifications@github.com wrote:

Michael --- if you want this fixed, could you be more specific about what's going wrong?

I'm pushing this issue off indefinitely pending some indication of what's broken.

—
Reply to this email directly or view it on GitHub.