-
-
Notifications
You must be signed in to change notification settings - Fork 380
Open
Labels
Milestone
Description
Summary:
These were issues that were noticed when code reviewing for #1751. @bob-carpenter spotted most of these.
Description:
- Change
gradient_samples
argument to the algorithm to something closer to "size of the sample" or "number of draws" - in
fullrank
andmeanfield
, rather thancont_params.resize(cont_vector.size());
, we should use anEigen::Map
- document
@throw
and@return
properly. Currently,run()
looks like it can only return 0, but it does throw.
Current Version:
v2.14.0