From d15f4dcdcd0619c6f6766510738c17d1755f4038 Mon Sep 17 00:00:00 2001 From: Mohammad Alhashash Date: Mon, 21 Jun 2021 13:58:12 +0200 Subject: [PATCH] Fix check failure when there is a wild card CNAME record If there is a wildcard CNAME record "*.domain.com", resolving `_acme-challenge.domain.com` would yield another domain. Getssl incorrectly updates the check domain with the resolved domain which causes check failure! Let's Encrypt validation does not follow CNAME of the challenge domain and Getssl should not too. --- getssl | 3 --- 1 file changed, 3 deletions(-) diff --git a/getssl b/getssl index 1998d820..fae7cee1 100755 --- a/getssl +++ b/getssl @@ -1257,9 +1257,6 @@ for d in "${alldomains[@]}"; do if [[ -z "$AUTH_DNS_SERVER" ]]; then # Find authorative dns server for _acme-challenge.{domain} (for CNAMES/acme-dns) get_auth_dns "${rr}" - if test -n "${cname}"; then - rr=${cname} - fi # If no authorative dns server found, try again for {domain} if [[ -z "$primary_ns" ]]; then