fix: all e2e tests fixed, added back failfast

Author: qykr

.github/workflows/ci.yml

@@ -57,7 +57,7 @@ jobs:
       run: go run ./cmd/sqlc-test-setup start
 
     - name: test ./...
-      run: gotestsum --junitfile junit.xml -- --tags=examples -timeout 20m ./... #TODO: Change back to -failfast
+      run: gotestsum --junitfile junit.xml -- --tags=examples -timeout 20m -failfast ./...
       env:
         CI_SQLC_PROJECT_ID: ${{ secrets.CI_SQLC_PROJECT_ID }}
         CI_SQLC_AUTH_TOKEN: ${{ secrets.CI_SQLC_AUTH_TOKEN }}

internal/compiler/resolve.go

@@ -346,7 +346,6 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar,
 
 	addColumnParam := func(ref paramRef, key string, location int) error {
 		var schema, rel string
-		// TODO: Deprecate defaultTable
 		if defaultTable != nil {
 			schema = defaultTable.Schema
 			rel = defaultTable.Name