move create & update account actions with services to spree (#532)

* move create & update account actions with services to spree

* restore deleted spec

* restart build with updated spree

* restart build with updated spree

* Require Spree 4.3

* fix gemspec

* restart build

Co-authored-by: Damian Legawiec <[email protected]>

Author: KacperMekarski

.travis.yml

@@ -23,13 +23,10 @@ env:
   - DB=postgres
 
 gemfile:
-  - gemfiles/spree_4_1.gemfile
+  - gemfiles/spree_4_3.gemfile
   - gemfiles/spree_master.gemfile
 
 jobs:
-  exclude:
-  - rvm: 3.0
-    gemfile: gemfiles/spree_4_1.gemfile
   allow_failures:
   - gemfile: gemfiles/spree_master.gemfile
 

Appraisals

@@ -1,6 +1,6 @@
-appraise 'spree-4-1' do
+appraise 'spree-4-3' do
   gem 'rails-controller-testing'
-  gem 'spree', '~> 4.1'
+  gem 'spree', github: 'spree/spree', branch: 'master'
 end
 
 appraise 'spree-master' do

app/services/spree/account/create.rb

@@ -3,6 +3,6 @@
 source "https://rubygems.org"
 
 gem "rails-controller-testing"
-gem "spree", "~> 4.1"
+gem "spree", github: "spree/spree", branch: "master"
 
 gemspec path: "../"

app/services/spree/account/update.rb

@@ -27,6 +27,33 @@
     end
   end
 
+  describe 'validations' do
+    context 'email' do
+      let(:user) { build(:user, email: nil) }
+
+      it 'cannot be empty' do
+        expect(user.valid?).to be false
+        expect(user.errors.messages[:email].first).to eq "can't be blank"
+      end
+    end
+
+    context 'password' do
+      let(:user) { build(:user, password_confirmation: nil) }
+
+      it 'password confirmation cannot be empty' do
+        expect(user.valid?).to be false
+        expect(user.errors.messages[:password_confirmation].first).to eq "doesn't match Password"
+      end
+
+      let(:user) { build(:user, password: 'pass1234', password_confirmation: 'pass') }
+
+      it 'passwords has to be equal to password confirmation' do
+        expect(user.valid?).to be false
+        expect(user.errors.messages[:password_confirmation].first).to eq "doesn't match Password"
+      end
+    end
+  end
+
   context '#destroy' do
     it 'will soft delete with uncompleted orders' do
       order = build(:order)

gemfiles/spree_4_1.gemfile renamed to gemfiles/spree_4_3.gemfile

@@ -33,7 +33,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'devise', '~> 4.7'
   s.add_dependency 'devise-encryptable', '0.2.0'
 
-  spree_version = '>= 4.1', '< 5.0'
+  spree_version = '>= 4.3.0.alpha'
   s.add_dependency 'spree_core', spree_version
   s.add_dependency 'spree_extension'