This repository was archived by the owner on Jul 12, 2023. It is now read-only.
Remove redundant transitions #827
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
============================================
+ Coverage 91.62% 91.72% +0.09%
+ Complexity 1924 1921 -3
============================================
Files 177 177
Lines 7550 7507 -43
Branches 459 456 -3
============================================
- Hits 6918 6886 -32
+ Misses 521 511 -10
+ Partials 111 110 -1 |
honnix
reviewed
May 4, 2020
| Event.triggerExecution(WORKFLOW_INSTANCE, Trigger.backfill("bf-1"), TRIGGER_PARAMETERS), 1L, 1L)); | ||
| events.add(SequenceEvent.create(Event.dequeue(WORKFLOW_INSTANCE, RESOURCE_IDS), 2L, 2L)); | ||
| // missing Event.submit(WORKFLOW_INSTANCE, EXECUTION_DESCRIPTION, "exec-1") | ||
| events.add(SequenceEvent.create(Event.submit(WORKFLOW_INSTANCE, EXECUTION_DESCRIPTION, "exec-1"), 3L, 3L)); |
Member
There was a problem hiding this comment.
This was done on purpose in #609, as reflected by the name of this test case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Description
Motivation and Context
Have you tested this? If so, how?
Checklist for PR author(s)
Checklist for PR reviewer(s)