Reforged 12->24 player trigger bugs

[speige]

Constants like PLAYER_NEUTRAL_PASSIVE Players changed from 15 to 27 when max players changed from 12 to 24. Code like Player(PLAYER_NEUTRAL_PASSIVE) still works, but code like Player(15) breaks when upgrading to reforged.

Do a global find/replace in war3map.j to these:
Player(12) to Player(PLAYER_NEUTRAL_AGGRESSIVE)
Player(13) to GetBJPlayerNeutralVictim()
Player(14) to GetBJPlayerNeutralExtra()
Player(15) to Player(PLAYER_NEUTRAL_PASSIVE)

Make sure not to run it on a map that's already been updated to reforged, because that would cause real players in 24-player maps to be converted to neutral players.

[Luashine]

My reply from here https://www.hiveworkshop.com/threads/desync-when-calling-preloader-locally.360261/post-3683282:

TLDR: you cannot make a decision without observing the value in .w3i first. https://lep.nrw/jassbot/doc/GetBJMaxPlayers

[QUOTE="Smeto, post: 3674230, member: 302288"]
It turns out this code is fully functional, do you know what the problem is? That in 1.26 14,15 these were computers, and in Reforged it was already the player, and the lines in the Pld file were desynchronous because of this. All that was needed was to increase them by 12))))
[/QUOTE]
[USER=302288]@Smeto[/USER]  [USER=132502]@PurgeandFire[/USER] This is technically not correct.:grin: Reforged can still have 12-player maps when it detects an old map version in war3map.w3i. As I documented in jassdoc:
[QUOTE]
[B]GetBJMaxPlayers[/B]
                          
Returns the maximum number of playable player slots regardless of map options.
[LIST]
[*]Classic: 12 (hardcoded as [URL='https://lep.nrw/jassbot/doc/bj_MAX_PLAYERS']bj_MAX_PLAYERS[/URL])
[*]Reforged: 24
[/LIST]
[B]note[/B]
This is only affected by WorldEditor version (>=6060) specified in the map's war3map.w3i file. [URL='https://www.hiveworkshop.com/threads/success-hybrid-12-24-player-map-backwards-compatible-1-24-1-28-5-1-31.339722/']Further reading[/URL].
[/QUOTE]
:) Yes, if you work on your own map that's pretty much impossible for it to have an old war3map.w3i when you are working on Reforged. You will be misled to think Reforged [S]"always starts maps with 24 players"[/S], but this is not the case.