Skip to content

[spectro-release-4.7] PCP-5178: Release LXD VM during the upgrade of the hosted control plane cluster (#228) #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2025
Merged

[spectro-release-4.7] PCP-5178: Release LXD VM during the upgrade of the hosted control plane cluster (#228) #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions controllers/maasmachine_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"strings"
"time"

"github.com/spectrocloud/maas-client-go/maasclient"
"k8s.io/apimachinery/pkg/runtime"

"github.com/go-logr/logr"
Expand Down Expand Up @@ -225,6 +226,34 @@ func (r *MaasMachineReconciler) reconcileDelete(_ context.Context, machineScope
// If MAAS requires VM host removal first, attempt best-effort unregister and retry once
if isVMHostRemovalRequiredError(err) {
api := clusterScope.GetMaasClientIdentity()

// For control-plane BM that backs an LXD VM host, force-delete guest VMs to unblock release
if clusterScope.IsLXDHostEnabled() && machineScope.IsControlPlane() {
ctx := context.Background()
client := maasclient.NewAuthenticatedClientSet(api.URL, api.Token)
if hosts, herr := client.VMHosts().List(ctx, nil); herr == nil {
for _, h := range hosts {
if h.HostSystemID() == m.ID {
if guests, gerr := h.Machines().List(ctx); gerr == nil {
for _, g := range guests {
gid := g.SystemID()
if gid == "" {
continue
}
// Fetch details to confirm and delete
if gm, ge := client.Machines().Machine(gid).Get(ctx); ge == nil {
if derr := client.Machines().Machine(gm.SystemID()).Delete(ctx); derr != nil {
machineScope.Error(derr, "failed to delete guest VM during host release cleanup", "guestSystemID", gm.SystemID())
}
}
}
}
break
}
}
}
}

// choose ExternalIP first, then InternalIP
nodeIP := getNodeIP(m.Addresses)
if nodeIP != "" {
Expand Down